Skip to content

Fix domain name and routes for AWS Proxy extension #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whummer merged 3 commits into from
Sep 22, 2025
Merged

Fix domain name and routes for AWS Proxy extension #105

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb10608
fix domain name and routes for AWS Proxy extension
whummer Sep 22, 2025
268dbf1
adjust check to new Python version 3.13
whummer Sep 22, 2025
a94c2f7
rename CI build file; bump Python version in CI
whummer Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/aws-replicator.yml
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@nik-localstack nik-localstack Sep 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We could rename the workflow file to aws-proxy.yml and we could also change the python version here (Set up Python step) to 3.13 (same as LocalStack)
I can make these changes in a follow-up PR though after this get merged.

Copy link
Copy Markdown
Member Author

@whummer whummer Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great points - thanks for the detailed review! 🙌 Updated the PR with those changes.. 👍

Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ jobs:
pip install awscli-local[ver1]
pip install terraform-local

find /home/runner/.cache/localstack/volume/lib/extensions/python_venv/lib/python3.11/site-packages/aws*
ls -la /home/runner/.cache/localstack/volume/lib/extensions/python_venv/lib/python3.11/site-packages/aws*
find /home/runner/.cache/localstack/volume/lib/extensions/python_venv/lib/python3.*/site-packages/aws*
ls -la /home/runner/.cache/localstack/volume/lib/extensions/python_venv/lib/python3.*/site-packages/aws*
DEBUG=1 GATEWAY_SERVER=hypercorn localstack start -d
localstack wait

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ You can install the respective extension by calling `localstack install <Install

| Extension | Install name | Version | Support status |
|----------------------------------------------------------------------------------------------------| ------------ |---------| -------------- |
| [AWS Proxy](https://github.com/localstack/localstack-extensions/tree/main/aws-proxy) | localstack-extension-aws-proxy | 0.2.0 | Experimental |
| [AWS Proxy](https://github.com/localstack/localstack-extensions/tree/main/aws-proxy) | localstack-extension-aws-proxy | 0.2.1 | Experimental |
| [Diagnosis Viewer](https://github.com/localstack/localstack-extensions/tree/main/diagnosis-viewer) | localstack-extension-diagnosis-viewer | 0.1.0 | Stable |
| [Hello World](https://github.com/localstack/localstack-extensions/tree/main/hello-world) | localstack-extension-hello-world | 0.1.0 | Stable |
| [httpbin](https://github.com/localstack/localstack-extensions/tree/main/httpbin) | localstack-extension-httpbin | 0.1.0 | Stable |
Expand Down
10 changes: 5 additions & 5 deletions aws-proxy/aws_proxy/server/request_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

LOG = logging.getLogger(__name__)

DOMAIN_NAME = f"aws-replicator.{LOCALHOST_HOSTNAME}"
DOMAIN_NAME = f"aws-proxy.{LOCALHOST_HOSTNAME}"
ROUTE_HOST = f"{DOMAIN_NAME}<port:port>"


Expand Down Expand Up @@ -71,17 +71,17 @@ def set_status(self, request: Request, **kwargs):

@route("/", methods=["GET"], host=ROUTE_HOST)
def forward_from_root(self, request: Request, **kwargs):
return redirect(f"{INTERNAL_RESOURCE_PATH}/aws-replicator/index.html")
return redirect(f"{INTERNAL_RESOURCE_PATH}/aws-proxy/index.html")

@route(f"{INTERNAL_RESOURCE_PATH}/aws-replicator", methods=["GET"])
@route(f"{INTERNAL_RESOURCE_PATH}/aws-proxy", methods=["GET"])
def forward_from_extension_root(self, request: Request, **kwargs):
return redirect(f"{INTERNAL_RESOURCE_PATH}/aws-replicator/index.html")
return redirect(f"{INTERNAL_RESOURCE_PATH}/aws-proxy/index.html")

@route("/favicon.png", methods=["GET"], host=ROUTE_HOST)
def serve_favicon(self, request: Request, **kwargs):
return self.serve_static_file("/favicon.png")

@route(f"{INTERNAL_RESOURCE_PATH}/aws-replicator/<path:path>", methods=["GET"])
@route(f"{INTERNAL_RESOURCE_PATH}/aws-proxy/<path:path>", methods=["GET"])
def get_web_asset(self, request: Request, path: str, **kwargs):
return self.serve_static_file(path)

Expand Down
2 changes: 1 addition & 1 deletion aws-proxy/aws_proxy/server/ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<title>AWS Replicator - LocalStack Extension</title>
<title>AWS Cloud Proxy - LocalStack Extension</title>
<link rel="shortcut icon" href="/favicon.png" />
<script src="https://unpkg.com/react@18.3.1/umd/react.development.js"></script>
<script src="https://unpkg.com/react-dom@18.3.1/umd/react-dom.development.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion aws-proxy/example/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ test: ## Run the end-to-end test with a simple sample app
echo "Creating SQS queue in real AWS"; \
aws sqs create-queue --queue-name test-queue1; \
queueUrl=$$(aws sqs get-queue-url --queue-name test-queue1 | jq -r .QueueUrl); \
echo "Starting AWS replicator proxy"; \
echo "Starting AWS Proxy"; \
(DEBUG=1 localstack aws proxy -s s3,sqs --host 0.0.0.0 & ); \
echo "Deploying Terraform template locally"; \
tflocal init; \
Expand Down
4 changes: 2 additions & 2 deletions aws-proxy/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[metadata]
name = localstack-extension-aws-proxy
version = 0.2.0
summary = LocalStack AWS Proxy Extension
version = 0.2.1
summary = LocalStack AWS Cloud Proxy
description = Proxy AWS resources into your LocalStack instance
long_description = file: README.md
long_description_content_type = text/markdown; charset=UTF-8
Expand Down