Reduce log level for skip_verification_paths from WARNING to DEBUG#25
Open
alexrashed wants to merge 1 commit into
Open
Reduce log level for skip_verification_paths from WARNING to DEBUG#25alexrashed wants to merge 1 commit into
alexrashed wants to merge 1 commit into
Conversation
Skipping specific snapshot paths is a deliberate, common call-site choice and not a condition worth surfacing as a warning to all consumers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bblommers
approved these changes
Jun 10, 2026
bblommers
left a comment
bblommers
left a comment
Contributor
There was a problem hiding this comment.
Makes sense! Removing unnecessary details from the logs is always welcome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_assert_all()logged atWARNINGwhenskip_verification_pathswas provided, but skipping specific paths is a deliberate and common choice - not an unexpected condition.This leads to polluted logs in our pipelines.
This PR reduces the log level from
WARNINGtoDEBUGso it only surfaces whenDEBUG_SNAPSHOTis set.Testing
Both of these scenarios have been tested by me manually locally:
WARNINGis emitted when skipping specific paths.DEBUGlevel whenDEBUG_SNAPSHOTis set