refactor(explore): rename filter→view, remove dead StandardModel code

- Remove unused StandardModel/loadStandardModel and resources/focuses/
- Rename src/views/localstack → src/views/explore to match the view name
- Migrate internal "filter" terminology to "view" (cloud-profile views):
  SavedView/ViewScope, getProfileViews, saveProfileView, removeProfileView,
  ProfileViewTreeItem, resolveRegionViewFocus, command IDs
  localstack.{add,edit,remove}ProfileView, contextValue localstackProfileView,
  and config key cloudProfiles.views

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: peter-smith-phd

package.json

@@ -65,7 +65,7 @@
 						"type": "string"
 					}
 				},
-				"localstack.cloudProfiles.filters": {
+				"localstack.cloudProfiles.views": {
 					"type": "object",
 					"default": {},
 					"markdownDescription": "User-defined resource views per AWS profile. Managed via the view's \"Add View...\" / \"Edit View...\" / \"Remove View\" actions.",
@@ -229,19 +229,19 @@
 				"icon": "$(settings-gear)"
 			},
 			{
-				"command": "localstack.addFilter",
+				"command": "localstack.addProfileView",
 				"title": "Add View...",
 				"category": "LocalStack",
 				"icon": "$(add)"
 			},
 			{
-				"command": "localstack.editFilter",
+				"command": "localstack.editProfileView",
 				"title": "Edit View...",
 				"category": "LocalStack",
 				"icon": "$(settings-gear)"
 			},
 			{
-				"command": "localstack.removeFilter",
+				"command": "localstack.removeProfileView",
 				"title": "Remove View",
 				"category": "LocalStack",
 				"icon": "$(trash)"
@@ -310,12 +310,12 @@
 					"group": "inline"
 				},
 				{
-					"command": "localstack.addFilter",
+					"command": "localstack.addProfileView",
 					"when": "view == localstack.instances && (viewItem == localstackDefaultRegion || viewItem == localstackUserRegion)",
 					"group": "1_region@1"
 				},
 				{
-					"command": "localstack.addFilter",
+					"command": "localstack.addProfileView",
 					"when": "view == localstack.instances && (viewItem == localstackDefaultRegion || viewItem == localstackUserRegion)",
 					"group": "inline@1"
 				},
@@ -330,23 +330,23 @@
 					"group": "inline@2"
 				},
 				{
-					"command": "localstack.editFilter",
-					"when": "view == localstack.instances && viewItem == localstackFilter",
+					"command": "localstack.editProfileView",
+					"when": "view == localstack.instances && viewItem == localstackProfileView",
 					"group": "1_modify@1"
 				},
 				{
-					"command": "localstack.editFilter",
-					"when": "view == localstack.instances && viewItem == localstackFilter",
+					"command": "localstack.editProfileView",
+					"when": "view == localstack.instances && viewItem == localstackProfileView",
 					"group": "inline@1"
 				},
 				{
-					"command": "localstack.removeFilter",
-					"when": "view == localstack.instances && viewItem == localstackFilter",
+					"command": "localstack.removeProfileView",
+					"when": "view == localstack.instances && viewItem == localstackProfileView",
 					"group": "1_modify@2"
 				},
 				{
-					"command": "localstack.removeFilter",
-					"when": "view == localstack.instances && viewItem == localstackFilter",
+					"command": "localstack.removeProfileView",
+					"when": "view == localstack.instances && viewItem == localstackProfileView",
 					"group": "inline@2"
 				},
 				{
@@ -393,15 +393,15 @@
 					"when": "false"
 				},
 				{
-					"command": "localstack.addFilter",
+					"command": "localstack.addProfileView",
 					"when": "false"
 				},
 				{
-					"command": "localstack.editFilter",
+					"command": "localstack.editProfileView",
 					"when": "false"
 				},
 				{
-					"command": "localstack.removeFilter",
+					"command": "localstack.removeProfileView",
 					"when": "false"
 				},
 				{

resources/focuses/everything-in-all-profiles.focus.json

@@ -4,14 +4,8 @@
  * and resources should be shown in the UI. The model is platform-neutral: AWS
  * (and future emulators) populate it via their own code under src/platforms/.
  */
-import * as fs from "node:fs";
-import path from "node:path";
-
 import * as z from "zod";
 
-import { InternalError } from "../utils/errors.ts";
-import { memoize } from "../utils/memoize.ts";
-
 const ResourceTypeFocus = z.object({
 	id: z.string(),
 	get arns() {
@@ -53,72 +47,6 @@ export type RegionFocus = z.infer<typeof RegionFocus>;
 export type ServiceFocus = z.infer<typeof ServiceFocus>;
 export type ResourceTypeFocus = z.infer<typeof ResourceTypeFocus>;
 
-/**
- * Standard focuses that are always available by default,
- * and can never be modified.
- */
-type StandardModelType = {
-	key: string;
-	name: string;
-};
-export const StandardModel = {
-	EVERYTHING_IN_DEFAULT_REGION: {
-		key: "everything-in-default-region",
-		name: "All Services in Default Region",
-	} satisfies StandardModelType,
-	EVERYTHING_IN_DEFAULT_PROFILE: {
-		key: "everything-in-default-profile",
-		name: "All Regions in Default Profile",
-	} satisfies StandardModelType,
-	EVERYTHING_IN_ALL_PROFILES: {
-		key: "everything-in-all-profiles",
-		name: "Everything in all Profiles",
-	} satisfies StandardModelType,
-
-	get all(): StandardModelType[] {
-		return [
-			StandardModel.EVERYTHING_IN_DEFAULT_REGION,
-			StandardModel.EVERYTHING_IN_DEFAULT_PROFILE,
-			StandardModel.EVERYTHING_IN_ALL_PROFILES,
-		];
-	},
-};
-
-/**
- * Load one of the standard (pre-defined, unmodifiable) focuses. The
- * result is memoized since the data will not change.
- */
-export const loadStandardModel = memoize(
-	(model: StandardModelType, extensionPath: string = "./") => {
-		const jsonString: string = fs.readFileSync(
-			path.resolve(
-				extensionPath,
-				"resources",
-				"focuses",
-				`${model.key}.focus.json`,
-			),
-			"utf-8",
-		);
-
-		let json: unknown;
-		try {
-			json = JSON.parse(jsonString);
-		} catch (error) {
-			throw new InternalError(
-				`Loading standard Focus '${model.key}': ${String(error)}`,
-			);
-		}
-
-		const result = Focus.safeParse(json);
-		if (!result.success) {
-			throw new InternalError(
-				`Loading standard Focus '${model.key}': ${z.prettifyError(result.error)}`,
-			);
-		}
-		return result.data;
-	},
-);
-
 /**
  * Build a wildcard focus that shows everything in a single profile/region.
  * The service wildcard (`*`) is expanded dynamically by the Resources view.

resources/focuses/everything-in-default-profile.focus.json

@@ -2,8 +2,8 @@ import { commands, window, workspace } from "vscode";
 
 import { ProviderFactory } from "../platforms/aws/services/providerFactory.ts";
 import { createPlugin } from "../plugins.ts";
-import { registerLocalStackCommands } from "../views/localstack/commands.ts";
-import { LocalStackViewProvider } from "../views/localstack/viewProvider.ts";
+import { registerLocalStackCommands } from "../views/explore/commands.ts";
+import { LocalStackViewProvider } from "../views/explore/viewProvider.ts";
 import { ResourceDetailsViewProvider } from "../views/resource-details/viewProvider.ts";
 import { ResourceArnTreeItem } from "../views/resources/treeItems.ts";
 import { ResourceViewProvider } from "../views/resources/viewProvider.ts";

resources/focuses/everything-in-default-region.focus.json

@@ -1,7 +1,7 @@
 import assert from "node:assert";
 
 import type { Focus } from "../../models/focus.ts";
-import { intersectMetamodelWithPairs } from "../../views/localstack/viewProvider.ts";
+import { intersectMetamodelWithPairs } from "../../views/explore/viewProvider.ts";
 
 /**
  * An instance view's focus is the live metamodel focus narrowed to the view's

src/models/focus.ts

@@ -0,0 +1,58 @@
+import assert from "node:assert";
+
+import type { SavedView } from "../../views/explore/settings.ts";
+import { resolveRegionViewFocus } from "../../views/explore/viewProvider.ts";
+
+/**
+ * The region (saved) view focus selector resolves its definition live
+ * from the current view list, so editing the active view is reflected on
+ * refresh and removing it yields no focus (clearing the Resources view).
+ */
+suite("resolveRegionViewFocus", () => {
+	const profile = "default";
+	const region = "us-east-1";
+
+	function view(resources: SavedView["resources"]): SavedView {
+		return { name: "My View", resources, scope: { region } };
+	}
+
+	test("resolves the focus from the matching view's pairs", () => {
+		const focus = resolveRegionViewFocus(profile, region, "My View", [
+			view([{ service: "sqs", resourceType: "queue" }]),
+		]);
+		assert.ok(focus);
+		const services = focus.profiles[0].regions[0].services;
+		assert.deepStrictEqual(
+			services.map((s) => s.id),
+			["sqs"],
+		);
+	});
+
+	test("reflects an edit to the view's pairs (live resolution)", () => {
+		/* Same name, different pairs — simulating an edit; the resolved focus
+		 * must reflect the new pairs, not a stale snapshot. */
+		const focus = resolveRegionViewFocus(profile, region, "My View", [
+			view([
+				{ service: "sqs", resourceType: "queue" },
+				{ service: "sns", resourceType: "topic" },
+			]),
+		]);
+		assert.ok(focus);
+		const serviceIds = focus.profiles[0].regions[0].services
+			.map((s) => s.id)
+			.sort();
+		assert.deepStrictEqual(serviceIds, ["sns", "sqs"]);
+	});
+
+	test("yields undefined when the named view is absent (removed/renamed)", () => {
+		const focus = resolveRegionViewFocus(
+			profile,
+			region,
+			"My View",
+			[view([{ service: "sqs", resourceType: "queue" }])].filter(
+				(v) => v.name !== "My View",
+			),
+		);
+		assert.strictEqual(focus, undefined);
+	});
+});