fix: check hostname for profile endpoint url#37
Merged
anisaoshafi merged 5 commits intomainfrom Sep 8, 2025
Merged
Conversation
Contributor
anisaoshafi
commented
Sep 8, 2025
anisaoshafi
commented
- Use uppercase "Override" in aws profile override.
- Check hostname instead of only http protocol (https should also work)
skyrpex
approved these changes
Sep 8, 2025
skyrpex
reviewed
Sep 8, 2025
Comment on lines
+60
to
+61
| parsed.port !== "" && // port must be present | ||
| (parsed.port === DEFAULT_PORT || /^\d+$/.test(parsed.port)) |
Contributor
There was a problem hiding this comment.
The condition parsed.port !== "" is unnecessary because later we check for (parsed.port === DEFAULT_PORT || /^\d+$/.test(parsed.port)
Contributor
There was a problem hiding this comment.
On a second thought, are we just trying to make sure there is a port, whatever it is? In that case, having parsed.port !== "" or just parsed.port only should be enough.
skyrpex
reviewed
Sep 8, 2025
Co-authored-by: Cristian Pallarés <cristian.pallares@localstack.cloud>
skyrpex
reviewed
Sep 8, 2025
Co-authored-by: Cristian Pallarés <cristian.pallares@localstack.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.