Skip to content

fix(style): adjust localstack aws profile #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anisaoshafi merged 2 commits into from
Sep 8, 2025
Merged

fix(style): adjust localstack aws profile #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c8686
style: adjust localstack aws profile
anisaoshafi Sep 8, 2025
cb08d0e
Address feedback
anisaoshafi Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
},
{
"command": "localstack.configureAwsProfiles",
"title": "Configure \"localstack\" AWS Profiles",
"title": "Configure AWS Profile \"localstack\"",
"category": "LocalStack"
}
],
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
},
});

window.withProgress(

Check warning on line 64 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
{
location: ProgressLocation.Notification,
title: "Setup LocalStack",
Expand Down Expand Up @@ -220,7 +220,7 @@

/////////////////////////////////////////////////////////////////////
progress.report({
message: "Configuring AWS profiles...",
message: "Configuring AWS profile...",
});
await minDelay(
configureAwsProfiles({
Expand All @@ -232,7 +232,7 @@
void commands.executeCommand("localstack.refreshStatusBar");

progress.report({
message: 'Finished configuring "localstack" AWS profiles.',
message: 'Finished configuring the "localstack" AWS profile.',
});
await minDelay(Promise.resolve());

Expand All @@ -257,25 +257,25 @@

/////////////////////////////////////////////////////////////////////
if (localStackStatusTracker.status() === "running") {
window

Check warning on line 260 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("LocalStack is running.", {
title: "View Logs",
command: "localstack.viewLogs",
})
.then((selection) => {
if (selection) {
commands.executeCommand(selection.command);

Check warning on line 267 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
} else {
window

Check warning on line 271 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("LocalStack is ready to start.", {
title: "Start LocalStack",
command: "localstack.start",
})
.then((selection) => {
if (selection) {
commands.executeCommand(selection.command);

Check warning on line 278 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
}
Expand All @@ -295,14 +295,14 @@
);

if (setupStatusTracker.status() === "setup_required") {
window

Check warning on line 298 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("Setup LocalStack to get started.", {
title: "Setup",
command: "localstack.setup",
})
.then((selected) => {
if (selected) {
commands.executeCommand(selected.command, "extension_startup");

Check warning on line 305 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
}
Expand Down
8 changes: 4 additions & 4 deletions src/utils/configure-aws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ export async function configureAwsProfiles(options: {
// if everything in place, show user that no changes were made and return
if (options?.notifyNoChangesMade) {
window.showInformationMessage(
'The "localstack" AWS profiles were already present, so no changes were made.',
'The "localstack" AWS profile was already present, so no changes were made.',
Copy link
Copy Markdown
Member

@joe4dev joe4dev Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "The AWS profile named "localstack" ...

Following AWS terminology using "named" in https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-files.html

Same for "Finished configuring ..."

);
}
options.telemetry?.track({
Expand All @@ -332,7 +332,7 @@ export async function configureAwsProfiles(options: {
});
return;
} else {
// profiles are there but need adjustment
// profile is there but needs adjustment
// in testing, we always override
if (options?.forceOverride) {
overrideDecision = "Override";
Expand All @@ -346,7 +346,7 @@ export async function configureAwsProfiles(options: {
}
}
} else {
// if any of the profiles don't exist, we need to create it
// we need to create it
overrideDecision = "Override";
}

Expand Down Expand Up @@ -464,7 +464,7 @@ export async function checkIsProfileConfigured(): Promise<boolean> {
return false;
}

return true; // Both profiles exist and are properly configured
return true; // profile exists in both files and is properly configured
} catch (error) {
return false;
}
Expand Down
Loading