rename azure emulator image to localstack/localstack-azure

Author: carole-lavillonniere

internal/config/containers.go

@@ -80,7 +80,7 @@ var knownImages = []struct {
 	{EmulatorAWS, "localstack-pro", true},
 	{EmulatorAWS, "localstack", false},
 	{EmulatorSnowflake, "snowflake", true},
-	{EmulatorAzure, "localstack-azure-alpha", true},
+	{EmulatorAzure, "localstack-azure", true},
 }
 
 func EmulatorTypeForImage(image string) EmulatorType {

internal/config/containers_test.go

@@ -121,11 +121,11 @@ func TestAzureEmulatorResolvesStartMetadata(t *testing.T) {
 
 	image, err := c.Image()
 	require.NoError(t, err)
-	assert.Equal(t, "localstack/localstack-azure-alpha:latest", image)
+	assert.Equal(t, "localstack/localstack-azure:latest", image)
 
 	productName, err := c.ProductName()
 	require.NoError(t, err)
-	assert.Equal(t, "localstack-azure-alpha", productName)
+	assert.Equal(t, "localstack-azure", productName)
 
 	healthPath, err := c.HealthPath()
 	require.NoError(t, err)
@@ -137,7 +137,7 @@ func TestAzureEmulatorResolvesStartMetadata(t *testing.T) {
 }
 
 func TestEmulatorTypeForImage_Azure(t *testing.T) {
-	assert.Equal(t, EmulatorAzure, EmulatorTypeForImage("localstack/localstack-azure-alpha:latest"))
+	assert.Equal(t, EmulatorAzure, EmulatorTypeForImage("localstack/localstack-azure:latest"))
 }
 
 func TestSelfValidatesLicense(t *testing.T) {

internal/container/start_test.go

@@ -157,7 +157,7 @@ func TestSelectContainersToStart_AttachesWhenExternalContainerOnConfiguredPort(t
 	}
 
 	mockRT.EXPECT().IsRunning(gomock.Any(), c.Name).Return(false, nil)
-	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure-alpha"}, "4566/tcp").
+	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure"}, "4566/tcp").
 		Return(&runtime.RunningContainer{Name: "external-container", Image: "localstack/localstack-pro:3.5.0", BoundPort: "4566"}, nil)
 	mockRT.EXPECT().ContainerEnv(gomock.Any(), "external-container").Return(nil, nil)
 
@@ -186,7 +186,7 @@ func TestSelectContainersToStart_AttachesWhenExternalContainerVersionDiffers(t *
 	}
 
 	mockRT.EXPECT().IsRunning(gomock.Any(), c.Name).Return(false, nil)
-	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure-alpha"}, "4566/tcp").
+	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure"}, "4566/tcp").
 		Return(&runtime.RunningContainer{Name: "external-container", Image: "localstack/localstack-pro:3.5.0", BoundPort: "4566"}, nil)
 	mockRT.EXPECT().ContainerEnv(gomock.Any(), "external-container").Return(nil, nil)
 
@@ -220,7 +220,7 @@ func TestSelectContainersToStart_QueuesContainerWhenNoneRunningOnPort(t *testing
 	}
 
 	mockRT.EXPECT().IsRunning(gomock.Any(), c.Name).Return(false, nil)
-	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure-alpha"}, "4566/tcp").
+	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure"}, "4566/tcp").
 		Return(nil, nil)
 
 	sink := output.NewPlainSink(io.Discard)
@@ -246,7 +246,7 @@ func TestSelectContainersToStart_ErrorsOnEmulatorTypeMismatch(t *testing.T) {
 	}
 
 	mockRT.EXPECT().IsRunning(gomock.Any(), c.Name).Return(false, nil)
-	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure-alpha"}, "4566/tcp").
+	mockRT.EXPECT().FindRunningByImage(gomock.Any(), []string{"localstack/localstack-pro", "localstack/localstack", "localstack/snowflake", "localstack/localstack-azure"}, "4566/tcp").
 		Return(&runtime.RunningContainer{Name: "localstack-aws", Image: "localstack/localstack-pro:latest", BoundPort: "4566"}, nil)
 
 	var out bytes.Buffer
@@ -363,7 +363,7 @@ func TestStartContainers_AzureLicenseError(t *testing.T) {
 	mockRT := runtime.NewMockRuntime(ctrl)
 
 	c := runtime.ContainerConfig{
-		Image:         "localstack/localstack-azure-alpha:latest",
+		Image:         "localstack/localstack-azure:latest",
 		Name:          "localstack-azure",
 		EmulatorType:  config.EmulatorAzure,
 		Tag:           "latest",

test/integration/start_test.go

@@ -713,8 +713,8 @@ func TestStartCommandSucceedsForAzure(t *testing.T) {
 	inspect, err := dockerClient.ContainerInspect(ctx, azureContainerName, client.ContainerInspectOptions{})
 	require.NoError(t, err, "failed to inspect azure container")
 	require.True(t, inspect.Container.State.Running, "azure container should be running")
-	assert.Contains(t, inspect.Container.Config.Image, "localstack/localstack-azure-alpha",
-		"expected localstack/localstack-azure-alpha image, got %s", inspect.Container.Config.Image)
+	assert.Contains(t, inspect.Container.Config.Image, "localstack/localstack-azure",
+		"expected localstack/localstack-azure image, got %s", inspect.Container.Config.Image)
 
 	resp, err := http.Get(fmt.Sprintf("http://localhost:%s/_localstack/health", hostPort))
 	require.NoError(t, err)