Skip to content

Commit 561ebdd

Browse files
authored
Show endpoint and tips when LocalStack is already running outside lstk (#216)
1 parent c3e3a22 commit 561ebdd

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

internal/container/start.go

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,15 @@ func runPostStartSetups(ctx context.Context, sink output.Sink, containers []conf
211211
return nil
212212
}
213213

214+
func emitAlreadyRunning(sink output.Sink, c runtime.ContainerConfig, localStackHost, webAppURL string) {
215+
sink.Emit(output.MessageEvent{Severity: output.SeverityNote, Text: "LocalStack is already running"})
216+
resolvedHost, dnsOK := endpoint.ResolveHost(c.Port, localStackHost)
217+
if !dnsOK {
218+
sink.Emit(output.MessageEvent{Severity: output.SeverityNote, Text: endpoint.DNSRebindNote})
219+
}
220+
emitPostStartPointers(sink, resolvedHost, webAppURL, c.EmulatorType == string(config.EmulatorAWS))
221+
}
222+
214223
func emitPostStartPointers(sink output.Sink, resolvedHost, webAppURL string, showTip bool) {
215224
sink.Emit(output.MessageEvent{Severity: output.SeveritySecondary, Text: fmt.Sprintf("• Endpoint: %s", resolvedHost)})
216225
if webAppURL != "" {
@@ -370,12 +379,7 @@ func selectContainersToStart(ctx context.Context, rt runtime.Runtime, sink outpu
370379
return nil, fmt.Errorf("failed to check container status: %w", err)
371380
}
372381
if running {
373-
sink.Emit(output.MessageEvent{Severity: output.SeverityNote, Text: "LocalStack is already running"})
374-
resolvedHost, dnsOK := endpoint.ResolveHost(c.Port, localStackHost)
375-
if !dnsOK {
376-
sink.Emit(output.MessageEvent{Severity: output.SeverityNote, Text: endpoint.DNSRebindNote})
377-
}
378-
emitPostStartPointers(sink, resolvedHost, webAppURL, c.EmulatorType == string(config.EmulatorAWS))
382+
emitAlreadyRunning(sink, c, localStackHost, webAppURL)
379383
continue
380384
}
381385

@@ -402,7 +406,7 @@ func selectContainersToStart(ctx context.Context, rt runtime.Runtime, sink outpu
402406
})
403407
return nil, output.NewSilentError(fmt.Errorf("LocalStack already running on port %s", found.BoundPort))
404408
}
405-
sink.Emit(output.MessageEvent{Severity: output.SeverityInfo, Text: "LocalStack is already running"})
409+
emitAlreadyRunning(sink, c, localStackHost, webAppURL)
406410
continue
407411
}
408412

0 commit comments

Comments
 (0)