Reject pod:// with an error

Author: anisaoshafi

internal/snapshot/destination.go

@@ -61,8 +61,11 @@ func ParseDestination(dest string, now time.Time) (Destination, error) {
 	} else {
 		lower := strings.ToLower(dest)
 		switch {
+		case strings.HasPrefix(lower, "pod://"):
+			podName := dest[len("pod://"):]
+			return Destination{}, fmt.Errorf("'%s' is not a valid reference. Aliases use a single colon. Did you mean:\npod:%s", dest, podName)
 		case strings.HasPrefix(lower, "pod:"):
-			podName := strings.TrimPrefix(dest[len("pod:"):], "//")
+			podName := dest[len("pod:"):]
 			if !validPodName.MatchString(podName) {
 				return Destination{}, fmt.Errorf("invalid pod name %q: use letters, digits, and hyphens only, starting with a letter or digit", podName)
 			}

internal/snapshot/destination_test.go

@@ -200,10 +200,9 @@ func TestParseDestination(t *testing.T) {
 			wantPodName: "my-baseline",
 		},
 		{
-			// pod:// is also accepted
-			input:       "pod://my-baseline",
-			wantKind:    snapshot.KindPod,
-			wantPodName: "my-baseline",
+			name:    "pod:// rejected with did-you-mean hint",
+			input:   "pod://my-baseline",
+			wantErr: "not a valid reference. Aliases use a single colon. Did you mean:\npod:my-baseline",
 		},
 		{
 			input:       "pod:abc123",