fix: propagate os.UserHomeDir() errors in snapshot save and load#342
Merged
anisaoshafi merged 1 commit intoJun 26, 2026
Merged
Conversation
gtsiolis
force-pushed
the
devx-938-snapshot-saveload-silently-drop-osuserhomedir-errors
branch
from
6e608c4 to
6b91f98
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
gtsiolis
force-pushed
the
devx-938-snapshot-saveload-silently-drop-osuserhomedir-errors
branch
from
6b91f98 to
fce2b61
Compare
gtsiolis
added
semver: patch
docs: skip
anisaoshafi
deleted the
devx-938-snapshot-saveload-silently-drop-osuserhomedir-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runSnapshotSaveandrunSnapshotLoadwere silently ignoring the error fromos.UserHomeDir()(home, _ := os.UserHomeDir()), passing an empty home path toParseSource/ParseDestinationwhen the home directory cannot be resolvedrunSnapshotRemovein the same file already handled this correctly — this brings the other two functions in lineTest plan
lstk snapshot saveandlstk snapshot loadreturn a clear error when the home directory cannot be resolved, rather than silently computing a wrong path🤖 Generated with Claude Code