Skip to content

Commit 09f294b

Browse files
committed
Revert "add runtime type for wrapped records (#23)"
This reverts commit 469d815.
1 parent 8190aa4 commit 09f294b

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

src/py_avro_schema/_schemas.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -325,20 +325,14 @@ def _wrap_as_record(self, inner_schema: JSONObj, names: NamesType) -> JSONType:
325325
if fullname in names:
326326
return fullname
327327
names.append(fullname)
328-
329-
fields = [
330-
{"name": REF_ID_KEY, "type": ["null", "long"], "default": None},
331-
{"name": REF_DATA_KEY, "type": inner_schema},
332-
]
333-
if Option.ADD_RUNTIME_TYPE_FIELD in self.options:
334-
fields.append({"name": RUNTIME_TYPE_KEY, "type": ["null", "string"]})
335-
336328
record_schema = {
337329
"type": "record",
338330
"name": record_name,
339-
"fields": fields,
331+
"fields": [
332+
{"name": REF_ID_KEY, "type": ["null", "long"], "default": None},
333+
{"name": REF_DATA_KEY, "type": inner_schema},
334+
],
340335
}
341-
342336
if self.namespace:
343337
record_schema["namespace"] = self.namespace
344338
return record_schema

tests/test_avro_schema.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,3 @@ class PyType:
8080
],
8181
}
8282
assert_schema(PyType, expected, options=pas.Option.ADD_RUNTIME_TYPE_FIELD)
83-
84-
85-
def test_add_type_field_on_wrapped_record():
86-
py_type = list[str]
87-
expected = {
88-
"type": "record",
89-
"name": "StrList",
90-
"fields": [
91-
{"name": "__id", "type": ["null", "long"], "default": None},
92-
{"name": "__data", "type": {"type": "array", "items": "string"}},
93-
{"name": "_runtime_type", "type": ["null", "string"]},
94-
],
95-
}
96-
assert_schema(py_type, expected, options=pas.Option.WRAP_INTO_RECORDS | pas.Option.ADD_RUNTIME_TYPE_FIELD)

0 commit comments

Comments
 (0)