Fix annotated refs when using future annotations for plain classes#10
Merged
Conversation
bentsku
approved these changes
Nov 12, 2025
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM, this looks like a safe change 👍 kudos for spotting it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing with the framework, I did realize that generating the schema from plain classes was not working with
from __future__ import annotations, as this import defers the evaluation at runtime and keeps the annotations as strings.In this PR we use
get_type_hintsinstead of fetching the raw annotations to circumvent the problem.Added a reproducible test.
Fixes PNX-479