Skip to content

Adding schema for typing.Final#9

Merged
giograno merged 3 commits into
mainfrom
final-types
Nov 13, 2025
Merged

Adding schema for typing.Final#9
giograno merged 3 commits into
mainfrom
final-types

Conversation

@giograno
Copy link
Copy Markdown
Member

@giograno giograno commented Nov 11, 2025

While looking at the StepFunctions provider, I realized that our framework does not handle the typing.Final annotation.

For instance, for the following code:

class MyType:
   var: typing.Final[str]

the schema generation fails since there is no handler for Final.

We are fixing this by introducing a schema for typing.Final that simply strips out the subscribed type invoke that specific schema.

Closing PNX-474

@giograno giograno requested review from bentsku and thrau November 11, 2025 18:04
@giograno giograno self-assigned this Nov 11, 2025
Copy link
Copy Markdown

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@giograno giograno merged commit 737be58 into main Nov 13, 2025
6 checks passed
@giograno giograno deleted the final-types branch November 19, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants