make use_pro default to true and add deprecation warnings

Author: dominikschubert

.github/workflows/ci.yml

@@ -29,7 +29,6 @@ jobs:
               "image-tag": "3.2.0",
               "install-awslocal": "true",
               "configuration": "DEBUG=1",
-              "use-pro": "true",
             }
         env:
           # intentially left `LOCALSTACK_API_KEY` as env here, to ensure the fallback still works for old version
@@ -59,7 +58,6 @@ jobs:
               "image-tag": "latest",
               "install-awslocal": "true",
               "configuration": "DEBUG=1",
-              "use-pro": "true",
             }
         env:
           LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }}
@@ -111,7 +109,6 @@ jobs:
               "image-tag": "latest",
               "install-awslocal": "true",
               "configuration": "DEBUG=1",
-              "use-pro": "true",
               "state-name": "${{ needs.cloud-pods-save-test.outputs.pod-name }}",
               "state-action": "load"
             }
@@ -160,7 +157,6 @@ jobs:
               "image-tag": "latest",
               "install-awslocal": "true",
               "configuration": "DEBUG=1",
-              "use-pro": "true",
             }
         env:
           LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }}
@@ -202,7 +198,6 @@ jobs:
               "image-tag": "latest",
               "install-awslocal": "true",
               "configuration": "DEBUG=1",
-              "use-pro": "true",
               "state-name": "local-pods-test",
               "state-action": "load",
               "state-backend": "local",

README.md

@@ -25,8 +25,8 @@ A GitHub Action to setup [LocalStack](https://github.com/localstack/localstack)
   env:
     LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }}
 ```
-> **NOTE**: The `LOCALSTACK_AUTH_TOKEN` environment variable is required to be set if `use-pro` is set to `true`.  
-If the key is not found LocalStack by default falls back to the CE edition and displays a warning.
+> **NOTE**: The `LOCALSTACK_AUTH_TOKEN` environment variable is required. Since `use-pro` now defaults to `true`, the action will use the Pro image by default. 
+> The `use-pro` input will be removed in a future release.
 
 ### Install only CLIs and startup later
 ```yml
@@ -122,7 +122,7 @@ with:
 | `state-action`     | Valid values are `load`, `save`, `start`, `stop`, `''` (empty, don't manage state). Values `start`/`stop` only usable with app previews.  | `''` |
 | `state-backend`    | Either store the state of LocalStack locally, as a Cloud Pod or start an Ephemeral Instance. Valid values are `cloud-pods`, `ephemeral` or `local`. Use this option in unison with `state-action` to control behaviour. | `cloud-pods`  |
 | `state-name`       | Name of the state artifact (without extension) | `false`  |
-| `use-pro`          | Whether to use the Pro version of LocalStack (requires Auth Token to be configured) | `false`  |
+| `use-pro`          | Whether to use the Pro version of LocalStack (requires Auth Token to be configured). Will be removed in a future release. | `true`  |
 
 ## Example workflow
 ```yml
@@ -142,7 +142,6 @@ jobs:
           image-tag: 'latest'
           install-awslocal: 'true'
           configuration: DEBUG=1
-          use-pro: 'true'
           state-backend: cloud-pods
           state-action: load
           state-name: my-cloud-pod

action.yml

@@ -16,9 +16,10 @@ inputs:
     required: true
     default: 'true'
   use-pro:
-    description: 'Whether to use LocalStack Pro (requires a valid CI Auth Token)'
+    description: 'Deprecated. Whether to use LocalStack Pro (requires a valid CI Auth Token)'
     required: false
-    default: 'false'
+    default: 'true'
+    deprecationMessage: 'use-pro is deprecated and will be removed in a future release. The pro image is now the default.'
   configuration:
     description: 'Configuration variables to use for LocalStack'
     required: false

startup/action.yml

@@ -11,9 +11,10 @@ inputs:
     required: true
     default: 'true'
   use-pro:
-    description: 'Whether to use LocalStack Pro (requires a valid CI Auth Token)'
+    description: 'Deprecated. Whether to use LocalStack Pro (requires a valid CI Auth Token)'
     required: false
-    default: 'false'
+    default: 'true'
+    deprecationMessage: 'use-pro is deprecated and will be removed in a future release. The pro image is now the default.'
   configuration:
     description: 'Configuration variables to use for LocalStack'
     required: false
@@ -62,7 +63,10 @@ runs:
     - name: Start LocalStack
       run: |
         if [ "$USE_PRO" = true ]; then
-          if [ "x$LOCALSTACK_AUTH_TOKEN" = "x" -o "x$LOCALSTACK_API_KEY" = "x" ]; then
+          if [ "x$LOCALSTACK_API_KEY" != "x" ]; then
+            echo "WARNING: LOCALSTACK_API_KEY is deprecated, please use LOCALSTACK_AUTH_TOKEN instead."
+          fi
+          if [ "x$LOCALSTACK_AUTH_TOKEN" = "x" -a "x$LOCALSTACK_API_KEY" = "x" ]; then
             echo "WARNING: LocalStack Auth Token not detected, please verify your configuration..."
           fi
           CONFIGURATION="DNS_ADDRESS=127.0.0.1 ${CONFIGURATION}"