fix(#82): handle provider version as list in .terraform.lock.hcl#83
Merged
bentsku merged 1 commit intolocalstack:mainfrom Jul 3, 2025
Merged
Conversation
Contributor
|
edit: I'm currently trying it out locally, and trying to run the CI again to see if it's a real issue. Will keep you updated 👍 CI is now green, I wonder what happened 😄 |
bentsku
approved these changes
Jul 3, 2025
Contributor
bentsku
left a comment
There was a problem hiding this comment.
LGTM, this seems like a fair change! Thanks for providing a fix, and welcome to the contributors! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a TypeError that occurs when .terraform.lock.hcl contains the version field as a string, but recent versions of Terraform may emit the value as a list. This causes a TypeError within the get_provider_version_from_lock_file() function.
.terraform.lock.hcl content
Error returned from /bin/tflocal
TypeError: expected string or bytes-like object, got 'list'Fix
This fix checks for a list and safely parses the first element if necessary.