pinned dependencies to current working versions#86
pinned dependencies to current working versions#86alexrashed merged 3 commits intolocalstack:mainfrom
Conversation
alexrashed
left a comment
There was a problem hiding this comment.
Unfortunately, these are pretty drastic changes. We explicitly do not pin any of these versions, because tflocal is often installed in environments with other Python packages installed. Strictly requiring specific versions of dependencies most certainly creates conflicts in these environments. This is why we cannot / will not pin these dependencies down to a single version.
We could mitigate the issue you are seeing right now by excluding just this one broken version (f.e. like this).
What do you think?
Thats fair enough, yep thats a reasonable solution. have updated! |
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution and for the discussion on the topic! The changes are looking good, and I just locally verified the issue and that the new version constraint fixes the import error.
I'll directly move forward, merge the PR, and push a new version.
|
FYI: |
Resolves #85
This PR addresses a breaking change introduced by a recent update to the
python-hcl2package, as detailed in amplify-education/python-hcl2#242. The issue stemmed from an overlooked new dependency inpython-hcl2which disrupted tflocal's functionality.To enhance stability and prevent similar issues going forwards, all external dependencies have been pinned. This approach, excluding LocalStack-specific dependencies, allows for more controlled management of updates and mitigates risks associated with unannounced dependency changes.