use build instead of setuptools to create the dist, build wheel#88
Merged
alexrashed merged 1 commit intomainfrom Jul 24, 2025
Merged
use build instead of setuptools to create the dist, build wheel#88alexrashed merged 1 commit intomainfrom
alexrashed merged 1 commit intomainfrom
Conversation
Closed
silv-io
approved these changes
Jul 24, 2025
Member
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM!
Maybe in the future uv build and uv publish ;P
Member
Author
|
I absolutely don't see a reason to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently use
setuptoolsand thesdistcommand to create a source distribution before publishing the dist with twine.But direct invocations of
setup.pyhave been deprecated, and we want to publish a wheel distribution as well.This PR switches to
buildwhich solves both of these issues.Fixes #78.
Changes
buildinstead of directly invokingsetup.pyto build a source and wheel distribution before publishing.