Skip to content

use setup-localstack instead of conftest start#92

Merged
alexrashed merged 1 commit intomainfrom
use-pro
Feb 25, 2026
Merged

use setup-localstack instead of conftest start#92
alexrashed merged 1 commit intomainfrom
use-pro

Conversation

@alexrashed
Copy link
Copy Markdown
Member

Motivation

Currently, this repo starts the Community edition of LocalStack in the conftest.py.
This will require an auth token after the consolidation of our images.
This is why this PR removes the conftest but instead uses our own LocalStack GitHub action to start LocalStack with an auth token before executing the tests (and tear it down before stopping the pipeline).

Changes

  • Remove conftest.py which only stated and stopped LocalStack Community
  • Add a step to the workflow to start LocalStack with a CI auth token instead

Fixes ENG-395.

@alexrashed alexrashed requested a review from k-a-il February 24, 2026 12:42
@alexrashed alexrashed added the enhancement New feature or request label Feb 24, 2026
Copy link
Copy Markdown

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@alexrashed alexrashed merged commit 4169c2e into main Feb 25, 2026
3 checks passed
@alexrashed alexrashed deleted the use-pro branch February 25, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants