Skip to content

Commit 11edbb5

Browse files
authored
fix(workflows): correct filepath in ena-submission-image workflow (#6164)
An incorrect filepath was passed to `hashFiles()` in the ena-submission-image workflow. As far as I can tell, `hashFiles()` will just compute the hash using the other files that were correctly specified, silently ignoring the incorrect path. This means the image was not being rebuilt when the workflow file changed. (I did a quick pass of other places we use `hashFiles()`, there the paths seem to be in order) ### PR Checklist ~- [ ] All necessary documentation has been adapted.~ ~- [ ] The implemented feature is covered by appropriate, automated tests.~ ~- [ ] Any manual testing that has been done is documented (i.e. what exactly was tested?)~ 🚀 Preview: Add `preview` label to enable
1 parent e1c77d4 commit 11edbb5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/ena-submission-image.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
- name: Generate files hash
5656
id: files-hash
5757
run: |
58-
DIR_HASH=$(echo -n ${{ hashFiles('ena-submission/**', '.github/workflows/ena-submission-image.yml') }})
58+
DIR_HASH=$(echo -n ${{ hashFiles('ena-submission/**', '.github/workflows/ena-submission-image.yaml') }})
5959
echo "DIR_HASH=$DIR_HASH${{ env.BUILD_ARM == 'true' && '-arm' || '' }}" >> $GITHUB_ENV
6060
- name: Setup Docker metadata
6161
id: dockerMetadata

0 commit comments

Comments
 (0)