fix(deployment): default k3s image and --k3s-image argument in deploy.py#6151
Conversation
--k3s-image argument to deploy.py--k3s-image argument to deploy.py
--k3s-image argument to deploy.py--k3s-image argument in deploy.py
|
Claude finished @tombch's task in 1m 17s —— View job Code Review
Good fix for a real usability issue. The root cause analysis and default version choice are well-reasoned, and the inline comments explaining why v1.31 is used are helpful. One bug to address: since Minor: the |
anna-parker
left a comment
There was a problem hiding this comment.
see slack thread: https://loculus.slack.com/archives/C06JCAZLG14/p1773836281787349
I encountered an issue running
./deploy.py cluster --devand./deploy.py helm --devas-is. When running./deploy.py helm --dev, I would get:It turns out this was because the
k3d cluster createcommand does not specify the k3s image, and was installing a version of k3s that uses traefik v3 rather than v2. K3s version 1.32 and above installs traefik v3 by default: https://docs.k3s.io/upgrades#version-specific-caveats .This PR adds a
--k3s-imageargument fordeploy.py cluster, with the image defaulting to rancher/k3s:v1.31.14-k3s1 which resolves the helm issue. The user can also choose to use a different image if they want to.I'm not really aware of where this deployment script is used, so I am curious if anyone already encountered this issue (I saw there is an issue open for upgrading traefik: #6014).
PR Checklist
🚀 Preview: Add
previewlabel to enable