Skip to content

fix(config): reduced preprocessing replicas from 2 to 1#6181

Merged
anna-parker merged 2 commits into
mainfrom
fix-prepro-replicas
Mar 25, 2026
Merged

fix(config): reduced preprocessing replicas from 2 to 1#6181
anna-parker merged 2 commits into
mainfrom
fix-prepro-replicas

Conversation

@tombch

@tombch tombch commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Discussed with Anya - we said it looks like the replicas for Loculus preprocessing should be one instead of two.

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: Add preview label to enable

@tombch
tombch marked this pull request as ready for review March 25, 2026 14:03
@claude

claude Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Claude finished @tombch's task in 40s —— View job


Code Review

  • Gather context and read changed files
  • Review the change

This is a minimal, focused change — reducing the default preprocessing replicas from 2 to 1 in kubernetes/loculus/values.yaml.

Summary: The change is straightforward and correct in isolation. A few observations worth noting:

  • No test coverage needed — this is a configuration default, not application logic.
  • No documentation impact — the change is self-explanatory.
  • Missing PR context — the checklist items are unchecked and there's no linked issue. It would be helpful to briefly explain why this was reduced (e.g. resource constraints, over-provisioning, observed idle replicas) so future readers understand the intent.
  • Potential concern — reducing from 2 to 1 removes redundancy for the preprocessing service. If this is a production default, consider whether a single replica is acceptable for availability. If this is only for local/dev defaults or to reduce resource usage in shared environments, that's reasonable — but worth calling out explicitly.

The helm lint validation mentioned in kubernetes/CLAUDE.md should be run to confirm the values file is still valid after the change.

@claude claude Bot added deployment Code changes targetting the deployment infrastructure config Configuration related issues, i.e. helm processing labels Mar 25, 2026
@anna-parker
anna-parker merged commit 7533b88 into main Mar 25, 2026
61 checks passed
@anna-parker
anna-parker deleted the fix-prepro-replicas branch March 25, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration related issues, i.e. helm processing deployment Code changes targetting the deployment infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants