fix(website): fix note tooltip on review card#6630
Merged
Conversation
The secondary-messages note indicator on the review card placed `data-tooltip-id` directly on the `<Note>` SVG icon. react-tooltip v6's anchor resolution walks the DOM only through `HTMLElement` nodes and skips `SVGElement` nodes, so the anchor was never found and the tooltip never appeared on hover. Wrap the icon in a `<span>` that carries `data-tooltip-id`, matching the pattern used by `HoverTooltip` and the fix in #6628 for the edit page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
anna-parker
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[claude below]
Summary
Follow-up to #6628, which fixed the same class of bug on the edit page.
The secondary-messages note indicator on the review card (
ReviewCard.tsx) placeddata-tooltip-iddirectly on the<Note>SVG icon (~icons/fluent/note-24-filled). react-tooltip v6'sresolveDataTooltipAnchorwalks up the DOM tree but only considers nodes that areinstanceof HTMLElement. SVG elements areSVGElement, notHTMLElement, so the library skipped the icon entirely and never found the anchor — meaning the tooltip never appeared on hover.This is the only remaining instance of the pattern: I audited all 19
data-tooltip-idusages inwebsite/src, and every other one is attached to a real HTML element (<label>,<span>,<div>,<p>,<Button>→<button>,<ListboxOption>), which react-tooltip handles correctly.Fix
Wrap the
<Note>icon in a<span>that carries thedata-tooltip-id, matching the pattern used byHoverTooltipand the fix applied in #6628.PR Checklist
🤖 Generated with Claude Code
🚀 Preview: Add
previewlabel to enable