Skip to content

feat(website): Add confirmation dialog for citation deletion #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theosanderson merged 1 commit into from
Jul 16, 2026
Merged

feat(website): Add confirmation dialog for citation deletion #6919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration-tests/tests/pages/admin.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class AdminPage {
async deleteCitation(sourceDOI: string) {
const row = this.getCitationRow(sourceDOI);
await row.getByTestId('delete-citation-button').click();
await this.page.getByRole('button', { name: 'Confirm' }).click();
await expect(row).toBeHidden();
}
}
18 changes: 12 additions & 6 deletions website/src/components/AdminDashboard/AdminSeqSetCitationsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { AdminSeqSetCitationsTable } from './AdminSeqSetCitationsTable';
import { BackendClient } from '../../services/backendClient';
import type { ClientConfig } from '../../types/runtimeConfig';
import type { AdminSeqSetCitation } from '../../types/seqSetCitation';
import { displayConfirmationDialog } from '../ConfirmationDialog';

interface Props {
citations: AdminSeqSetCitation[];
Expand All @@ -25,7 +26,7 @@ export const AdminSeqSetCitationsSection: FC<Props> = ({ citations, clientConfig
]);
};

const handleDelete = async (sourceDOI: string) => {
const deleteCitation = async (sourceDOI: string) => {
const result = await backendClient.deleteSeqSetCitation(accessToken, sourceDOI);
result.match(
() => {
Expand All @@ -41,14 +42,19 @@ export const AdminSeqSetCitationsSection: FC<Props> = ({ citations, clientConfig
);
};

const handleDelete = (sourceDOI: string) => {
const citation = citationList.find((c) => c.source.sourceDOI === sourceDOI);
const citationLabel = citation?.source.title ?? sourceDOI;
displayConfirmationDialog({
dialogText: `Are you sure you want to remove the citation "${citationLabel}"?`,
onConfirmation: () => deleteCitation(sourceDOI),
});
};

return (
<>
<div className='overflow-x-auto'>
<AdminSeqSetCitationsTable
citations={citationList}
// eslint-disable-next-line @typescript-eslint/no-misused-promises
onDelete={handleDelete}
/>
<AdminSeqSetCitationsTable citations={citationList} onDelete={handleDelete} />
</div>
<AddSeqSetCitationForm
clientConfig={clientConfig}
Expand Down
Loading