Skip to content

Commit b1ad3be

Browse files
authored
fix(android): pull to refresh not working for short ScrollViews (#570)
* fix(android): skip scroll intercept workaround when RefreshControl is present * docs: update changelog
1 parent c9dc42a commit b1ad3be

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### 🐛 Bug fixes
6+
7+
- **Android**: Fixed pull to refresh not working for short ScrollViews. ([#570](https://github.com/lodev09/react-native-true-sheet/pull/570) by [@lodev09](https://github.com/lodev09))
8+
59
## 3.9.7
610

711
### 🐛 Bug fixes

android/src/main/java/com/lodev09/truesheet/core/TrueSheetCoordinatorLayout.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import android.view.MotionEvent
77
import android.view.ViewConfiguration
88
import android.widget.ScrollView
99
import androidx.coordinatorlayout.widget.CoordinatorLayout
10+
import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
1011
import com.facebook.react.uimanager.PointerEvents
1112
import com.facebook.react.uimanager.ReactPointerEventsView
1213
import com.lodev09.truesheet.utils.isDescendantOf
@@ -98,7 +99,9 @@ class TrueSheetCoordinatorLayout(context: Context) :
9899
}
99100

100101
val scrollView = delegate?.findScrollView()
102+
val hasRefreshControl = scrollView?.parent is SwipeRefreshLayout
101103
val cannotScroll = scrollView != null &&
104+
!hasRefreshControl &&
102105
scrollView.scrollY == 0 &&
103106
!scrollView.canScrollVertically(1)
104107

0 commit comments

Comments
 (0)