Replies: 2 comments 1 reply
-
|
Hey @bc-tinker.. what exactly is not working for you? I'm already doing that internally: react-native-true-sheet/src/TrueSheet.web.tsx Line 491 in c9dc42a |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
k, it looks like this is totally on me @lodev09 . I thought we were passing in scrollable where we weren't. That and a combination of adding ScrollViews, got everything working perfect. Thanks! Feel free to close. thanks @bc-tinker for posting this and thanks @lodev09 for being willing to help. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
It appears from our testing and from a note we saw somewhere that for the web implementation settings detents to 'auto' doesn't work correctly. This is an issue for us since the majority of our sheets are auto sized for mobile and forcing a detent on them for web would cause the content to look incorrect. Since the Truesheets web implementation uses @gorhom/bottom-sheet, it should be possible to support detents={['auto']} by enabling dynamic sizing internally.
Proposal
When detents includes 'auto' in the web implementation, automatically pass:
enableDynamicSizing={true}to the underlying Gorhom Bottom Sheet.
In our previous implementation using Gorhom Bottom Sheet directly (prior to migrating to TrueSheet), we enabled enableDynamicSizing to ensure dynamically sized modals correctly auto-sized to their content. This worked reliably for our use case and allowed 'auto' behavior without requiring fixed numeric detents.
Enabling this internally would allow:
to size to content height on web without additional configuration.
Acceptance Criteria
Beta Was this translation helpful? Give feedback.
All reactions