Replies: 1 comment 1 reply
-
|
Hey @steeeeee, thanks for the feedback! I think these are good additions/options for flexibility.
Feel free to open PRs, separately per feature |
Beta Was this translation helpful? Give feedback.
-
|
Hey @steeeeee, thanks for the feedback! I think these are good additions/options for flexibility.
Feel free to open PRs, separately per feature |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @lodev09! I'm integrating TrueSheet as the native bottom sheet in a React Navigation setup (New Architecture).
It's been great to work with, thanks for building this!
I've hit a few gaps where I've built local patches. Before I keep maintaining them as patch-package overrides, I'd love to contribute them upstream if you're open to PRs.
footerOptionsto include footer in auto detent calculationCurrently the
autodetent measures content + header but not the footer, since it is floating. For sticky action buttons at the bottom, the sheet ends up too short. I'd propose an optionalfooterOptionsprop (consistent withscrollableOptions, grabberOptions, blurOptions) to opt in:overlay(default): current behavior, non-breakingfixed: footer height included in auto detent, content scrolls past footeronBackdropPresscallbackWhen users tap the backdrop, there's no way to intercept it: the sheet either dismisses or ignores (if dismiss=false).
I'd like to run a callback instead of dismissing (e.g., for confirmation dialogs). Swipe-down behavior would remain unchanged.
The docs mention scroll view detection is limited to 2 levels deep on iOS. When using design system layout wrappers, in some cases the
ScrollViewends up deeper and isn't found. I noticed Android'sfindScrollViewalready searches recursively: would you be open to matching that on iOS, or would asearchDepthoption inscrollableOptionsbe preferred?Happy to submit these as separate PRs with tests and docs. Would you be open to contributions like these?
Beta Was this translation helpful? Give feedback.
All reactions