fix(web): clip form-sheet parent box; mirror iOS cascade rules#687
Merged
Conversation
…hild - Extract setClip helper to unify CLIP_NONE reset and dedupe writes - Add cornerRadius to cascade effect deps (was stale closure) - Mirror iOS: form parent with page child skips cascade transform — the page fully covers the form, so the push-down would only peek mid-animation
Walking all descendants pushed an ancestor further when a grandchild opened — even when the immediate child stayed put (e.g., child skipped its cascade for a page grandchild), leaving a visible gap.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related fixes to form-sheet stacking on web.
getBoundingClientRect) to get the at-rest box, unskewed by vaul's slide-in.clip-pathanimates with the same duration/easing as the cascade transform so the visible box and the drawer content slide together.Type of Change
Test Plan
maindoes not shift further when grandchild opens;basicskips cascade for page grandchild.Checklist