refactor(android): use EventDispatcherListener for screen events#438
Merged
Conversation
Replace fragment-based observer with event-based approach. Uses EventDispatcherListener to intercept screen lifecycle events.
Child sheets are rendered inside parent's coordinator layout, not in the screen hierarchy. Inherit parent's presenter tag.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
🚀 This pull request is included in v3.8.0-beta.0. See Release 3.8.0-beta.0 for release notes. |
Owner
Author
|
🚀 This pull request is included in v3.8.0. See Release 3.8.0 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the complex
RNScreensFragmentObserver(FragmentLifecycleCallbacks-based) with a simplerRNScreensEventObserverthat uses React Native'sEventDispatcherListenerto detect react-native-screens lifecycle events.Changes
RNScreensFragmentObserver.kt(266 lines) - Complex fragment lifecycle observer with activity lifecycle tracking, pending dismiss/pop runnables, and reflection-based modal detectionRNScreensEventObserver.kt(65 lines) - SimpleEventDispatcherListenerthat captures the presenter screen's view tag and listens fortopWillDisappear/topWillAppeareventspresenterScreenTagType of Change
Test Plan
Tested with react-native-screens navigation (push/pop) and stacked sheets.
Checklist