fix(android): emit didFocus after parent translate animation#666
Merged
fix(android): emit didFocus after parent translate animation#666
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
🚀 This pull request is included in v3.10.1. See Release 3.10.1 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, when a child sheet is dismissed in a stack, the parent's
onDidFocuswas firing immediately at the end of the child's dismiss animation — before the parent's translate-up animation began. It now fires after the parent's translate animation completes, so JS sees the focus event when the parent has visually settled back into place.Refactored the dismiss flow so event orchestration lives in
TrueSheetView.viewControllerDidDismissinstead of leaking intoresetTranslation:translateSheetaccepts an optionalonEndcallback wired throughwithEndActionresetTranslationstays pure — translate + cascade onlyStackManager.unregisterSheetis just a registry op (no return value)parentreference is passed through the delegate (washadParent: Boolean), so cross-container scenarios target the correct sheet for both translation and the focus eventisPresented && !isBeingDismissedso cascade dismiss (parent dismissing while child dismisses on top of it) doesn't fire focus on a dying parentType of Change
Test Plan
onDidFocusfires after parent slides back uponDidFocusevent (unchanged)dismissAllcascade → no spuriousonDidFocuson dying parentsChecklist