fix wrong dispatch mode causing frontend hangs

Author: loerting

composeApp/src/commonMain/kotlin/me/lkl/dalvikus/ui/editor/EditorView.kt

@@ -119,7 +119,7 @@ fun EditorView(tabElement: TabElement) {
     Scaffold(
         containerColor = Color.Transparent,
         floatingActionButton = {
-            if (viewModel.hasUnsavedChanges())
+            if (viewModel.hasUnsavedChanges() && !viewModel.isSaving)
                 ExtendedFloatingActionButton(
                     modifier = Modifier.padding(bottom = 8.dp, end = 8.dp),
                     onClick = { viewModel.saveCode(coroutine) },

composeApp/src/commonMain/kotlin/me/lkl/dalvikus/ui/editor/EditorViewModel.kt

@@ -46,6 +46,9 @@ class EditorViewModel(private val tab: TabElement) {
 
     val editable by mutableStateOf(tab.contentProvider.isEditable())
 
+    var isSaving by mutableStateOf(false)
+        private set
+
     var openable by
     mutableStateOf(tab.contentProvider.getSizeEstimate() < maxEditorFileSize && tab.contentProvider.isDisplayable())
         private set
@@ -89,7 +92,7 @@ class EditorViewModel(private val tab: TabElement) {
     }
 
     suspend fun loadCode() {
-        withContext(Dispatchers.IO) {
+        withContext(Dispatchers.Default) {
             tab.contentProvider.loadContent()
             internalContent = internalContent.copy(text = tab.contentProvider.contentFlow.value.decodeToString())
 
@@ -203,9 +206,13 @@ class EditorViewModel(private val tab: TabElement) {
 
     fun saveCode(coroutineScope: CoroutineScope) {
         if (!isLoaded) throw IllegalArgumentException("code not initialized.")
-        coroutineScope.launch(crtExHandler) {
+        isSaving = true
+        coroutineScope.launch(Dispatchers.Default + crtExHandler) {
             tab.contentProvider.updateContent(internalContent.text.toByteArray())
             tab.hasUnsavedChanges.value = false
+            withContext(Dispatchers.Main) {
+                isSaving = false
+            }
         }
     }
 

composeApp/src/commonMain/kotlin/me/lkl/dalvikus/ui/packaging/PackagingViewModel.kt

@@ -57,7 +57,7 @@ class PackagingViewModel() {
         apk: File,
         onError: (Throwable) -> Unit,
         onSuccess: (ApkVerifier.Result) -> Unit,
-    ) = withContext(Dispatchers.IO) {
+    ) = withContext(Dispatchers.Default) {
         try {
             val keystoreFile = keystoreInfo.keystoreFile
             val keyAlias = keystoreInfo.keyAlias
@@ -150,7 +150,7 @@ class PackagingViewModel() {
         onError: (Throwable) -> Unit,
         onSuccess: () -> Unit,
         packageName: String? = null
-    ) = withContext(Dispatchers.IO) {
+    ) = withContext(Dispatchers.Default) {
         // TODO add string resources for messages here.
         try {
             AndroidDebugBridge.init(false)

composeApp/src/commonMain/kotlin/me/lkl/dalvikus/ui/tree/TreeView.kt

@@ -19,6 +19,7 @@ import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
 import co.touchlab.kermit.Logger
+import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import me.lkl.dalvikus.snackbarManager
 import me.lkl.dalvikus.tree.ContainerNode
@@ -94,7 +95,7 @@ fun TreeView(
                     indent = indent,
                     isExpanded = expandedState[node] == true,
                     onToggleExpand = { shouldExpand ->
-                        coroutineScope.launch(crtExHandler) {
+                        coroutineScope.launch(Dispatchers.IO + crtExHandler) {
                             if (node is ContainerNode) {
                                 if (shouldExpand) {
                                     try {