Include SDPY fallback handling for HTTPSProxy Errors

andyvandy · coderabbitai[bot] · web-flow · commit 2b0cedf9ece7 · 2026-05-19T21:27:59.000-04:00
pick up the same additional error handling that was introduced by this commit to the kubectl client. kubernetes/kubectl@2c588bc Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
diff --git a/pkg/driver/kubernetes/client.go b/pkg/driver/kubernetes/client.go
@@ -125,7 +125,9 @@ func (c *Client) Exec(ctx context.Context, options *ExecStreamOptions) error {
 	if err != nil {
 		return err
 	}
-	exec, err := remotecommand.NewFallbackExecutor(websocketExec, spdyExec, httpstream.IsUpgradeFailure)
+	exec, err := remotecommand.NewFallbackExecutor(websocketExec, spdyExec, func(err error) bool {
+		return httpstream.IsUpgradeFailure(err) || httpstream.IsHTTPSProxyError(err)
+	})
 	if err != nil {
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,9 @@ func (c Client) Exec(ctx context.Context, options ExecStreamOptions) error {`
`125`	`125`	`if err != nil {`
`126`	`126`	`return err`
`127`	`127`	`}`
`128`		`- exec, err := remotecommand.NewFallbackExecutor(websocketExec, spdyExec, httpstream.IsUpgradeFailure)`
	`128`	`+ exec, err := remotecommand.NewFallbackExecutor(websocketExec, spdyExec, func(err error) bool {`
	`129`	`+ return httpstream.IsUpgradeFailure(err) \|\| httpstream.IsHTTPSProxyError(err)`
	`130`	`+ })`
`129`	`131`	`if err != nil {`
`130`	`132`	`return err`
`131`	`133`	`}`