fix(release): stop docs-sync PRs from carrying file-mode-only diffs#2469
Merged
Conversation
The versioned docs trees (platform_versioned_docs/version-*, etc.) were seeded from copies that carried an executable bit, so many committed partials are 100755 while the doc generators write them at 100644. The first successful sync into such a tree therefore flips the mode on hundreds of unchanged files: PR #2468 (v4.11.0) carried 112 spurious 100755->100644 mode-only diffs alongside only 4 real content changes (the go.mod/go.sum/vendor pin bump), burying the signal. Set core.fileMode false in the receiver so git ignores the executable bit for the sync. Docs (.mdx/.md/.json) are never executed, so the bit is meaningless; sync PRs now contain only real content changes. This is independent of the module-resolution fix in #2465 and applies to all sync event types. Claude-Session: https://claude.ai/code/session_011X7gGW9wWWJw1C5kq9aN2U
✅ Deploy Preview for vcluster-docs-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Successful docs-sync PRs carry hundreds of spurious file-mode-only diffs that bury the real content. Example: #2468 (v4.11.0 sync) had 116 changed files, but only 4 were real (the go.mod/go.sum/vendor pin bump). The other 112 were
100755 -> 100644mode flips on unchanged.mdxpartials.Root cause
The versioned docs trees (
platform_versioned_docs/version-*, etc.) were seeded from copies that carried an executable bit, so many committed partials are100755. The doc generators write their output at100644. The first successful sync into such a tree therefore flips the mode on every unchanged file. This is independent of the module-resolution fix in #2465; it surfaced now only because #2465 let the v4.11.0 sync reach the generate + commit steps for the first time.The fix
Set
git config core.fileMode falsein the receiver before it generates and opens the PR. Docs files (.mdx,.md,.json) are never executed, so the executable bit is meaningless. With it ignored, sync PRs contain only real content changes. Applies to all sync event types (platform, vcluster, cli).Notes
handle-source-release.yml; actionlint clean.@netlify /docs
https://claude.ai/code/session_011X7gGW9wWWJw1C5kq9aN2U