Skip to content

Commit 213e5bd

Browse files
committed
Added method to fetch project versions using GitHub API, removed hardcoded versions in tests.
1 parent 552c3aa commit 213e5bd

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

tests/download_helpers/github.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,15 @@ def testGetLatestVersion(self):
7777
download_helper = github.GitHubReleasesDownloadHelper(self._DOWNLOAD_URL)
7878

7979
latest_version = download_helper.GetLatestVersion(self._PROJECT_NAME, None)
80-
latest_version_api = download_helper.GetLatestVersionWithAPI(
81-
self._PROJECT_NAME, None)
80+
latest_version_api = download_helper.GetLatestVersionWithAPI(None)
8281

8382
self.assertEqual(latest_version, latest_version_api)
8483

8584
def testGetDownloadURL(self):
8685
"""Tests the GetDownloadURL functions."""
8786
download_helper = github.GitHubReleasesDownloadHelper(self._DOWNLOAD_URL)
8887

89-
project_version = download_helper.GetLatestVersionWithAPI(
90-
self._PROJECT_NAME, None)
88+
project_version = download_helper.GetLatestVersionWithAPI(None)
9189

9290
download_url = download_helper.GetDownloadURL(
9391
self._PROJECT_NAME, project_version)
@@ -128,8 +126,7 @@ def testGetLatestVersion(self):
128126
download_helper = github.GitHubReleasesDownloadHelper(self._DOWNLOAD_URL)
129127

130128
latest_version = download_helper.GetLatestVersion(self._PROJECT_NAME, None)
131-
latest_version_api = download_helper.GetLatestVersionWithAPI(
132-
self._PROJECT_NAME, None)
129+
latest_version_api = download_helper.GetLatestVersionWithAPI(None)
133130

134131

135132
self.assertEqual(latest_version, latest_version_api)
@@ -138,8 +135,7 @@ def testGetDownloadURL(self):
138135
"""Tests the GetDownloadURL functions."""
139136
download_helper = github.GitHubReleasesDownloadHelper(self._DOWNLOAD_URL)
140137

141-
project_version = download_helper.GetLatestVersionWithAPI(
142-
self._PROJECT_NAME, None)
138+
project_version = download_helper.GetLatestVersionWithAPI(None)
143139

144140
download_url = download_helper.GetDownloadURL(
145141
self._PROJECT_NAME, project_version)

0 commit comments

Comments
 (0)