Skip to content

Commit d6ca522

Browse files
committed
Added method to fetch project versions using GitHub API, removed hardcoded versions in tests.
1 parent 213e5bd commit d6ca522

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

l2tdevtools/download_helpers/github.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,16 @@ def GetLatestVersionWithAPI(self, version_definition):
108108
api_response = json.loads(page_content)
109109
release_names = [release['name'] for release in api_response]
110110

111-
expression_string = '({0:s})'.format('|'.join(self._VERSION_EXPRESSIONS))
111+
version_expressions = [
112+
'({0:s})$'.format(version_expression)
113+
for version_expression
114+
in self._VERSION_EXPRESSIONS]
115+
112116
versions = []
113117
for release in release_names:
114-
version_strings = re.findall(expression_string, release)
115-
versions.extend(version_strings)
118+
for version_expression in version_expressions:
119+
version_strings = re.findall(version_expression, release)
120+
versions.extend(version_strings)
116121

117122
available_versions = self._GetAvailableVersions(versions)
118123
return self._GetLatestVersion(

0 commit comments

Comments
 (0)