Changes to not catch exception related to coding errors

Author: joachimmetz

plaso/engine/single_process.py

@@ -33,6 +33,7 @@ def __init__(self):
     self._processing_configuration = None
     self._status_update_callback = None
 
+  # pylint: disable=missing-raises-doc
   def _ProcessPathSpec(self, extraction_worker, parser_mediator, path_spec):
     """Processes a path specification.
 
@@ -49,10 +50,16 @@ def _ProcessPathSpec(self, extraction_worker, parser_mediator, path_spec):
       excluded_find_specs = (
           self.collection_filters_helper.excluded_file_system_find_specs)
 
+    # pylint: disable=try-except-raise
     try:
       extraction_worker.ProcessPathSpec(
           parser_mediator, path_spec, excluded_find_specs=excluded_find_specs)
 
+    # Raise on coding errors.
+    except (AttributeError, ImportError, NameError, TypeError,
+            UnboundLocalError):
+      raise
+
     except KeyboardInterrupt:
       self._abort = True
 

plaso/multi_processing/analysis_process.py

@@ -145,6 +145,7 @@ def _Main(self):
 
     storage_writer.WriteTaskStart()
 
+    # pylint: disable=try-except-raise
     try:
       logger.debug(
           '{0!s} (PID: {1:d}) started monitoring event queue.'.format(
@@ -179,6 +180,11 @@ def _Main(self):
 
         self._analysis_mediator.ProduceAnalysisReport(self._analysis_plugin)
 
+    # Raise on coding errors.
+    except (AttributeError, ImportError, NameError, TypeError,
+            UnboundLocalError):
+      raise
+
     # All exceptions need to be caught here to prevent the process
     # from being killed by an uncaught exception.
     except Exception as exception:  # pylint: disable=broad-except

plaso/multi_processing/worker_process.py

@@ -168,6 +168,7 @@ def _Main(self):
 
     self._status = definitions.STATUS_INDICATOR_RUNNING
 
+    # pylint: disable=try-except-raise
     try:
       logger.debug('{0!s} (PID: {1:d}) started monitoring task queue.'.format(
           self._name, self._pid))
@@ -189,6 +190,11 @@ def _Main(self):
       logger.debug('{0!s} (PID: {1:d}) stopped monitoring task queue.'.format(
           self._name, self._pid))
 
+    # Raise on coding errors.
+    except (AttributeError, ImportError, NameError, TypeError,
+            UnboundLocalError):
+      raise
+
     # All exceptions need to be caught here to prevent the process
     # from being killed by an uncaught exception.
     except Exception as exception:  # pylint: disable=broad-except
@@ -228,6 +234,7 @@ def _Main(self):
     except errors.QueueAlreadyClosed:
       logger.error('Queue for {0:s} was already closed.'.format(self.name))
 
+  # pylint: disable=missing-raises-doc
   def _ProcessPathSpec(self, extraction_worker, parser_mediator, path_spec):
     """Processes a path specification.
 
@@ -244,10 +251,16 @@ def _ProcessPathSpec(self, extraction_worker, parser_mediator, path_spec):
       excluded_find_specs = (
           self._collection_filters_helper.excluded_file_system_find_specs)
 
+    # pylint: disable=try-except-raise
     try:
       extraction_worker.ProcessPathSpec(
           parser_mediator, path_spec, excluded_find_specs=excluded_find_specs)
 
+    # Raise on coding errors.
+    except (AttributeError, ImportError, NameError, TypeError,
+            UnboundLocalError):
+      raise
+
     except dfvfs_errors.CacheFullError:
       # TODO: signal engine of failure.
       self._abort = True

plaso/parsers/esedb.py

@@ -60,6 +60,7 @@ def GetFormatSpecification(cls):
     format_specification.AddNewSignature(b'\xef\xcd\xab\x89', offset=4)
     return format_specification
 
+  # pylint: disable=missing-raises-doc
   def ParseFileObject(self, parser_mediator, file_object):
     """Parses an ESE database file-like object.
 
@@ -79,6 +80,7 @@ def ParseFileObject(self, parser_mediator, file_object):
 
     # Compare the list of available plugin objects.
     cache = ESEDBCache()
+
     try:
       table_names = frozenset(self._GetTableNames(esedb_file))
 
@@ -89,10 +91,16 @@ def ParseFileObject(self, parser_mediator, file_object):
         if not plugin.required_tables.issubset(table_names):
           continue
 
+        # pylint: disable=try-except-raise
         try:
           plugin.UpdateChainAndProcess(
               parser_mediator, cache=cache, database=esedb_file)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           parser_mediator.ProduceExtractionWarning((
               'plugin: {0:s} unable to parse ESE database with error: '

plaso/parsers/esedb_plugins/interface.py

@@ -220,6 +220,7 @@ def _GetRecordValue(self, record, value_entry):
       return long_value.get_data()
     return record.get_value_data(value_entry)
 
+  # pylint: disable=missing-raises-doc
   def _GetRecordValues(
       self, parser_mediator, table_name, record, value_mappings=None):
     """Retrieves the values from the record.
@@ -260,10 +261,16 @@ def _GetRecordValues(
                     self.NAME, value_callback_method, column_name, table_name))
 
       if value_callback:
+        # pylint: disable=try-except-raise
         try:
           value_data = record.get_value_data(value_entry)
           value = value_callback(value_data)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           logger.error(exception)
           value = None

plaso/parsers/olecf.py

@@ -41,6 +41,7 @@ def GetFormatSpecification(cls):
 
     return format_specification
 
+  # pylint: disable=missing-raises-doc
   def ParseFileObject(self, parser_mediator, file_object):
     """Parses an OLE Compound File (OLECF) file-like object.
 
@@ -81,19 +82,31 @@ def ParseFileObject(self, parser_mediator, file_object):
         if not plugin.REQUIRED_ITEMS.issubset(item_names):
           continue
 
+        # pylint: disable=try-except-raise
         try:
           plugin.UpdateChainAndProcess(parser_mediator, root_item=root_item)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           parser_mediator.ProduceExtractionWarning((
               'plugin: {0:s} unable to parse OLECF file with error: '
               '{1!s}').format(plugin.NAME, exception))
 
       if self._default_plugin and not parser_mediator.abort:
+        # pylint: disable=try-except-raise
         try:
           self._default_plugin.UpdateChainAndProcess(
               parser_mediator, root_item=root_item)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           parser_mediator.ProduceExtractionWarning((
               'plugin: {0:s} unable to parse OLECF file with error: '

plaso/parsers/safari_cookies.py

@@ -113,6 +113,7 @@ def _ParsePage(self, parser_mediator, file_offset, page_data):
 
       self._ParseRecord(parser_mediator, page_data, record_offset)
 
+  # pylint: disable=missing-raises-doc
   def _ParseRecord(self, parser_mediator, page_data, record_offset):
     """Parses a record from the page data.
 
@@ -178,11 +179,17 @@ def _ParseRecord(self, parser_mediator, page_data, record_offset):
       if event_data.cookie_name != plugin.COOKIE_NAME:
         continue
 
+      # pylint: disable=try-except-raise
       try:
         plugin.UpdateChainAndProcess(
             parser_mediator, cookie_name=event_data.cookie_name,
             cookie_data=event_data.cookie_value, url=event_data.url)
 
+      # Raise on coding errors.
+      except (AttributeError, ImportError, NameError, TypeError,
+              UnboundLocalError):
+        raise
+
       except Exception as exception:  # pylint: disable=broad-except
         parser_mediator.ProduceExtractionWarning(
             'plugin: {0:s} unable to parse cookie with error: {1!s}'.format(

plaso/parsers/sqlite.py

@@ -380,6 +380,7 @@ def GetFormatSpecification(cls):
     format_specification.AddNewSignature(b'SQLite format 3', offset=0)
     return format_specification
 
+  # pylint: disable=missing-raises-doc
   def ParseFileEntry(self, parser_mediator, file_entry):
     """Parses a SQLite database file entry.
 
@@ -428,11 +429,17 @@ def ParseFileEntry(self, parser_mediator, file_entry):
         parser_mediator.SetFileEntry(file_entry)
         parser_mediator.AddEventAttribute('schema_match', schema_match)
 
+      # pylint: disable=try-except-raise
         try:
           plugin.UpdateChainAndProcess(
               parser_mediator, cache=cache, database=database,
               database_wal=database_wal, wal_file_entry=wal_file_entry)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           parser_mediator.ProduceExtractionWarning((
               'plugin: {0:s} unable to parse SQLite database with error: '
@@ -454,6 +461,11 @@ def ParseFileEntry(self, parser_mediator, file_entry):
               parser_mediator, cache=cache, database=database,
               database_wal=database_wal, wal_file_entry=wal_file_entry)
 
+        # Raise on coding errors.
+        except (AttributeError, ImportError, NameError, TypeError,
+                UnboundLocalError):
+          raise
+
         except Exception as exception:  # pylint: disable=broad-except
           parser_mediator.ProduceExtractionWarning((
               'plugin: {0:s} unable to parse SQLite database and WAL with '

plaso/parsers/sqlite_plugins/chrome_cookies.py

@@ -102,6 +102,7 @@ def __init__(self):
     self._cookie_plugins = (
         cookie_plugins_manager.CookiePluginsManager.GetPlugins())
 
+  # pylint: disable=missing-raises-doc
   def ParseCookieRow(self, parser_mediator, query, row, **unused_kwargs):
     """Parses a cookie row.
 
@@ -165,11 +166,17 @@ def ParseCookieRow(self, parser_mediator, query, row, **unused_kwargs):
       if cookie_name != plugin.COOKIE_NAME:
         continue
 
+      # pylint: disable=try-except-raise
       try:
         plugin.UpdateChainAndProcess(
             parser_mediator, cookie_data=cookie_data, cookie_name=cookie_name,
             url=url)
 
+      # Raise on coding errors.
+      except (AttributeError, ImportError, NameError, TypeError,
+              UnboundLocalError):
+        raise
+
       except Exception as exception:  # pylint: disable=broad-except
         parser_mediator.ProduceExtractionWarning(
             'plugin: {0:s} unable to parse cookie with error: {1!s}'.format(

plaso/parsers/sqlite_plugins/interface.py

@@ -89,6 +89,7 @@ def _HashRow(cls, row):
 
     return hash(' '.join(values))
 
+  # pylint: disable=missing-raises-doc
   def _ParseQuery(self, parser_mediator, database, query, callback, cache):
     """Queries a database and parses the results.
 
@@ -118,9 +119,15 @@ def _ParseQuery(self, parser_mediator, database, query, callback, cache):
       if row_hash in row_cache:
         continue
 
+      # pylint: disable=try-except-raise
       try:
         callback(parser_mediator, query, row, cache=cache, database=database)
 
+      # Raise on coding errors.
+      except (AttributeError, ImportError, NameError, TypeError,
+              UnboundLocalError):
+        raise
+
       except Exception as exception:  # pylint: disable=broad-except
         parser_mediator.ProduceExtractionWarning((
             'unable to parse row: {0:d} with callback: {1:s} on database '