Changes to not catch exception related to coding errors

[joachimmetz]

Changes to not catch exception related to coding errors

[Onager]

Can you explain the rationale for this? Why would we want to crash at runtime if there's a bug?

[joachimmetz]

Can you explain the rationale for this? Why would we want to crash at runtime if there's a bug?

Pylint and unittests can catch these exceptions when not absorbed by the try except

let's chat about this, I've noticed a couple of time (not specific to plaso) that the broad try except absorbs some exception that could have been caught by the tests. Which then later on lead to other subtle issues.

[Onager]

I've noticed a couple of time (not specific to plaso) that the broad try except absorbs some exception that could have been caught by the tests. Which then later on lead to other subtle issues.

I can see this happening in tests, but I don't understand could catch any more problems with a specific try-catch block. Can you give an example?

[codecov]

Codecov Report

Merging #2522 (2425e32) into main (7b2a4e8) will decrease coverage by 0.07%.
The diff coverage is 21.87%.

@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   85.68%   85.60%   -0.08%     
==========================================
  Files         379      379              
  Lines       32389    32421      +32     
==========================================
+ Hits        27751    27755       +4     
- Misses       4638     4666      +28     

Impacted Files	Coverage Δ
plaso/engine/single_process.py	74.05% <0.00%> (-0.95%)	⬇️
plaso/multi_processing/analysis_process.py	33.60% <0.00%> (-0.55%)	⬇️
plaso/parsers/safari_cookies.py	82.90% <0.00%> (-1.45%)	⬇️
plaso/parsers/sqlite_plugins/chrome_cookies.py	95.40% <0.00%> (-2.25%)	⬇️
plaso/parsers/olecf.py	82.14% <20.00%> (-6.10%)	⬇️
plaso/parsers/sqlite.py	72.68% <20.00%> (-1.40%)	⬇️
plaso/multi_processing/worker_process.py	50.57% <25.00%> (-2.37%)	⬇️
plaso/parsers/esedb.py	88.23% <33.33%> (-2.54%)	⬇️
plaso/parsers/esedb_plugins/interface.py	65.83% <33.33%> (-0.62%)	⬇️
plaso/parsers/sqlite_plugins/interface.py	79.06% <33.33%> (-1.66%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2a4e8...2425e32. Read the comment docs.

[joachimmetz]

@Onager PTAL