Detach disabled devices after surface.Load (v4.1.33)

The pre-Load skip-attach in LoadDeviceProvider was moot: surface.Load
calls provider.Initialize() which populates provider.Devices, then
attaches every device in that collection to the surface
unconditionally. The manual loop above iterates against an empty
provider.Devices for async providers (Hue / LIFX) and is overridden
by Load even when it isn't.

Add a post-Load pass that walks provider.Devices, checks
MappingLayers.IsDeviceDisabled, and detaches the disabled ones from
the surface. _activeDevices is updated to false in the same pass so
the rest of the codebase (effect dispatch, brightness writes) sees a
consistent disabled state.

Symptom: a device disabled in the Mappings tab persisted the disable
state across restarts (v4.1.30 fix worked there), but layers and
effects continued to render to the hardware after the restart because
surface.Load had silently re-attached the device. This commit closes
that loop.

Build clean, 130/130 tests pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: logicallysynced

CHANGELOG.md

@@ -2,12 +2,12 @@
 
 All notable changes to Chromatics are documented here.
 
-## 4.1.32
+## 4.1.33
 
 - Added Auto-discovery for Hue bridges.
 - Updated Hue light adoption. After pairing, Chromatics shows a picker so you can choose exactly which Hue lights it should control. Existing setups upgraded from earlier builds keep all their bulbs (one-time auto-adopt of whatever the bridge currently exposes); from then on you can deselect bulbs you don't want from the same dialog.
 - Hue bulbs now restore their original colour and on/off state when Chromatics releases control — disabling Hue, disabling an individual bulb on the Mappings tab, or closing the app puts each bulb back the way you had it before adoption. Same UX as LIFX.
-- Disabling a device on the Mappings tab now sticks across restarts. Disabled devices still show in the Mappings list — re-enable from the same toggle and Chromatics will (re)take control.
+- Disabling a device on the Mappings tab now sticks across restarts.
 - Fixed an error that could appear in the log when disabling Hue (or any device provider) — "The device 'X' is not attached to this surface."
 
 

Chromatics/Chromatics.csproj

@@ -4,7 +4,7 @@
     <OutputType>WinExe</OutputType>
     <TargetFramework>net10.0-windows7.0</TargetFramework>
     <StartupObject>Chromatics.Program</StartupObject>
-    <Version>4.1.32.0</Version>
+    <Version>4.1.33.0</Version>
     <Authors>Danielle Thompson</Authors>
     <ApplicationManifest>app.manifest</ApplicationManifest>
     <Copyright>logicallysynced 2026</Copyright>

Chromatics/Core/RGBController.cs

@@ -744,6 +744,29 @@ public static bool LoadDeviceProvider(IRGBDeviceProvider provider)
                     surface.Load(provider);
                     loadedDeviceProviders.Add(provider);
 
+                    // surface.Load attaches every device in provider.Devices
+                    // unconditionally (the comment in DevicesChanged about
+                    // "startup attachment is owned by SurfaceExtensions.Load"
+                    // is the source of truth here). Our pre-Load skip-attach
+                    // loop above is moot for async providers (Hue/LIFX),
+                    // whose Devices collection is empty until Initialize
+                    // runs INSIDE Load. To honour the persisted disable
+                    // state we have to detach the disabled devices here,
+                    // AFTER Load has populated provider.Devices and put
+                    // them on the surface.
+                    foreach (var device in provider.Devices)
+                    {
+                        var guidProbe = Helpers.DeviceHelper.GenerateDeviceGuid(device.DeviceInfo.DeviceName);
+                        if (!Layers.MappingLayers.IsDeviceDisabled(guidProbe))
+                            continue;
+                        if (surface.Devices.Contains(device))
+                            surface.Detach(device);
+                        if (_activeDevices.ContainsKey(device))
+                            _activeDevices[device] = false;
+                        else
+                            _activeDevices.Add(device, false);
+                    }
+
                     if (_loaded)
                     {
                         StopEffects();

Chromatics/obj/Chromatics.csproj.nuget.dgspec.json

@@ -5,7 +5,7 @@
   },
   "projects": {
     "D:\\Git Projects\\roxaskeyheart\\Chromatics Workbench\\Chromatics\\Chromatics\\Chromatics.csproj": {
-      "version": "4.1.32",
+      "version": "4.1.33",
       "restore": {
         "projectUniqueName": "D:\\Git Projects\\roxaskeyheart\\Chromatics Workbench\\Chromatics\\Chromatics\\Chromatics.csproj",
         "projectName": "Chromatics",
@@ -31,7 +31,6 @@
         },
         "frameworks": {
           "net10.0-windows7.0": {
-            "framework": "net10.0-windows7.0",
             "targetAlias": "net10.0-windows7.0",
             "projectReferences": {}
           }
@@ -50,7 +49,6 @@
       },
       "frameworks": {
         "net10.0-windows7.0": {
-          "framework": "net10.0-windows7.0",
           "targetAlias": "net10.0-windows7.0",
           "dependencies": {
             "Avalonia": {

Chromatics/obj/project.assets.json

@@ -3697,7 +3697,7 @@
     "C:\\Program Files (x86)\\Microsoft Visual Studio\\Shared\\NuGetPackages": {}
   },
   "project": {
-    "version": "4.1.32",
+    "version": "4.1.33",
     "restore": {
       "projectUniqueName": "D:\\Git Projects\\roxaskeyheart\\Chromatics Workbench\\Chromatics\\Chromatics\\Chromatics.csproj",
       "projectName": "Chromatics",