fix serialization

Author: stevevillardi

Public/Set-LMOpsNote.ps1

@@ -76,7 +76,7 @@ function Set-LMOpsNote {
             }
 
             $Scope = @()
-            if ($ResourceIds -or $WebsiteIds -or $DeviceGroupIds) {
+            if ($DeviceIds -or $WebsiteIds -or $DeviceGroupIds) {
                 foreach ($deviceId in $DeviceIds) {
                     $Scope += [PSCustomObject]@{
                         type     = "device"
@@ -128,10 +128,18 @@ function Set-LMOpsNote {
                 $Data.tags = @()
             }
 
+            $alwaysKeepKeys = @()
+            if ($ClearTags) {
+                $alwaysKeepKeys += 'tags'
+            }
+            if ($PSBoundParameters.ContainsKey('DeviceIds') -or $PSBoundParameters.ContainsKey('WebsiteIds') -or $PSBoundParameters.ContainsKey('DeviceGroupIds')) {
+                $alwaysKeepKeys += 'scopes'
+            }
+
             $Data = Format-LMData `
                 -Data $Data `
                 -UserSpecifiedKeys $MyInvocation.BoundParameters.Keys `
-                -AlwaysKeepKeys @($(if ($ClearTags) { 'tags' } else { @() }))
+                -AlwaysKeepKeys $alwaysKeepKeys
 
             if ($PSCmdlet.ShouldProcess($Message, "Set Ops Note")) {
                 $Headers = New-LMHeader -Auth $Script:LMAuth -Method "PATCH" -ResourcePath $ResourcePath -Data $Data

Public/Set-LMRecipientGroup.ps1

@@ -18,7 +18,7 @@ The new name of the recipient group. This parameter is optional.
 The description of the recipient group. This parameter is optional.
 
 .PARAMETER Recipients
-A object containing the recipients for the recipient group.
+An array of recipient objects for the recipient group.
 
 .EXAMPLE
 $recipients = @(
@@ -56,7 +56,7 @@ function Set-LMRecipientGroup {
 
         [String]$Description,
 
-        [PSCustomObject]$Recipients
+        [Object[]]$Recipients
     )
 
     #Check if we are logged in and have valid api creds
@@ -90,14 +90,17 @@ function Set-LMRecipientGroup {
             $Data = @{
                 groupName   = $NewName
                 description = $Description
-                recipients  = $Recipients
+                recipients  = if ($PSBoundParameters.ContainsKey('Recipients')) { @($Recipients) } else { $null }
             }
 
             #Remove empty keys so we dont overwrite them
             $Data = Format-LMData `
                 -Data $Data `
                 -UserSpecifiedKeys $MyInvocation.BoundParameters.Keys `
-                -ConditionalKeep @{ 'name' = 'NewName' }
+                -ConditionalKeep @{
+                    'groupName'  = 'NewName'
+                    'recipients' = 'Recipients'
+                }
 
             if ($PSCmdlet.ShouldProcess($Message, "Set Recipient Group")) {
                 $Headers = New-LMHeader -Auth $Script:LMAuth -Method "PATCH" -ResourcePath $ResourcePath -Data $Data

Public/Set-LMRole.ps1

@@ -461,6 +461,16 @@ function Set-LMRole {
                 }
             }
 
+            $privilegeBoundParams = @(
+                'DashboardsPermission', 'ResourcePermission', 'LMXToolBoxPermission', 'LMXPermission',
+                'LogsPermission', 'WebsitesPermission', 'SavedMapsPermission', 'ReportsPermission', 'SettingsPermission',
+                'CreatePrivateDashboards', 'AllowWidgetSharing', 'ConfigTabRequiresManagePermission',
+                'AllowedToViewMapsTab', 'AllowedToManageResourceDashboards', 'ViewTraces', 'ViewSupport', 'EnableRemoteSessionForResources'
+            )
+
+            $updatingPrivileges = $PSCmdlet.ParameterSetName -like '*Custom*' -or
+                ($privilegeBoundParams | Where-Object { $PSBoundParameters.ContainsKey($_) })
+
             $Data = @{
                 customHelpLabel = $CustomHelpLabel
                 customHelpURL   = $CustomHelpURL
@@ -469,14 +479,23 @@ function Set-LMRole {
                 requireEULA     = if ($RequireEULA.IsPresent) { "true" }else { "" }
                 roleGroupId     = $RoleGroupId
                 twoFARequired   = if ($TwoFARequired.IsPresent) { "true" }else { "" }
-                privileges      = if ($CustomPrivilegesObject) { $CustomPrivilegesObject }else { $Privileges }
+            }
+
+            if ($updatingPrivileges) {
+                $Data.privileges = if ($CustomPrivilegesObject) { $CustomPrivilegesObject } else { $Privileges }
+            }
+
+            $alwaysKeepKeys = @()
+            if ($updatingPrivileges) {
+                $alwaysKeepKeys += 'privileges'
             }
 
             #Remove empty keys so we dont overwrite them
             $Data = Format-LMData `
                 -Data $Data `
                 -UserSpecifiedKeys $MyInvocation.BoundParameters.Keys `
-                -ConditionalKeep @{ 'name' = 'NewName' }
+                -ConditionalKeep @{ 'name' = 'NewName' } `
+                -AlwaysKeepKeys $alwaysKeepKeys
 
             if ($PSCmdlet.ShouldProcess($Message, "Set Role")) {