v2.1.1

stdio fix

Author: stevevillardi

CHANGELOG.md

@@ -1,3 +1,85 @@
+## 2.1.1
+
+### Bug Fix
+- **Stdio stdout pollution** – Fixed a bug where Winston log output and audit log entries were written to `stdout` during server startup in stdio mode. MCP clients reading stdout for JSON-RPC (Claude Desktop, Cursor, etc.) would fail with a Zod `invalid_union` validation error on the non-JSON-RPC log lines.
+- All Winston console transports now route to `stderr` in stdio mode, keeping `stdout` clean for JSON-RPC.
+- `AuditLogger` accepts a `useStderr` flag so its transport also writes to `stderr` in stdio mode.
+- `startStdioServer()` logger is no longer restricted to `error` level — all configured levels flow to `stderr`.
+
+---
+
+## 2.1.0
+
+### New Resources
+- **SDT (Scheduled Down Time)** – Full CRUD via `lm_sdt`. Supports oneTime, daily, weekly, monthly, and monthlyByWeek schedules targeting devices, device groups, websites, collectors, and datasources.
+- **OpsNotes** – Full CRUD via `lm_opsnote`. Scoped visibility (device, service, deviceGroup, serviceGroup) with tag-based categorization.
+
+### Intelligent Response Formatting (Token Reduction)
+- **Compact list views** – Lists with >5 items return key-field summary tables instead of full JSON.
+- **Time-series data optimization** – Device data responses include summary statistics (min/max/avg/latest) plus sampled data points.
+- **Batch result summaries** – Large batch operations return only failure details; full per-item results stored in session.
+- **Internal field stripping** – `raw`, `meta`, and `request` fields removed from tool responses.
+
+### Session Filtering Enhancements
+- `lm_session get` now supports `fields` (projection), `index` (single item), and `limit` (first N items) for on-demand filtering of stored results.
+
+### Improved Error Messages
+- API errors now include `errorMessage`, `errorCode`, and `errorDetail` from the LogicMonitor response body.
+- Status-based hints (404: verify IDs, 401/403: check permissions, 429: rate limited) help LLMs recover.
+
+### Device Data Reliability
+- **Relative time parsing** – Time parameters support `-6h`, `-24h`, `-7d`, `-30m`, `"now"`, ISO dates, and epoch seconds.
+- **Datasource ID disambiguation** – Tool descriptions clarify `id` vs `dataSourceId`.
+
+### Schema Flattening for MCP Clients
+- Fixed Zod v4 `oneOf` discriminated unions not recognized by MCP clients. ListTools handler now flattens both `anyOf` and `oneOf` formats.
+
+### LLM Evaluation Harness
+- New `tests/eval/` system with 60+ scenarios across 8 categories, multi-provider support (OpenAI GPT-4o, GPT-5.4), scoring engine, and multi-step workflow testing.
+
+### Audit Logging & Security
+- Structured audit logging for server events, auth, sessions, and tool calls.
+- Bearer tokens hashed with SHA-256.
+- Graceful shutdown with clean session closure on SIGTERM/SIGINT.
+
+### Winston Transport Leak Fix
+- Fixed memory leak in HTTP mode where session Winston transports were never removed on close.
+
+---
+
+## 2.0.0
+
+### Architecture Modernization
+- **Zod validation** – Migrated from Joi to Zod for compile-time type safety and discriminated unions.
+- **MCP SDK high-level API** – All tools use `registerTool()` instead of manual `setRequestHandler()`.
+- **Unified resource pattern** – Every tool follows `list`, `get`, `create`, `update`, `delete` operations.
+- **Enhanced batch operations** – Explicit arrays, session variable references (`applyToPrevious`), and filter-based operations.
+- **Smart pagination** – `autoPaginate` parameter for fine-grained control over result sets.
+
+### New Resource Coverage
+- **Device Data** – Datasources, instances, and performance metrics.
+- **Collector Groups** – Full CRUD for organizing collectors.
+- **Dashboards** – Create, update, and manage dashboards.
+- **Users** – Complete user management with role assignments and batch operations.
+
+### Developer Experience
+- Removed ~2,000 lines of deprecated code (Joi schemas, legacy tool definitions).
+- Standardized MCP error codes and validation messages.
+- 170+ tests covering CRUD, batch processing, field selection, and error handling.
+
+### Resource Health & Discovery
+- Field metadata resources (`health://logicmonitor/fields/{resource}`).
+- Per-tool health telemetry via `health://logicmonitor/status`.
+- Enhanced session tool for variables, history, and multi-step context.
+
+### Breaking Changes
+- Tool input schemas now use `operation` parameter instead of separate tools per operation.
+- Switched from Joi to Zod validation.
+- Omit `fields` parameter for all fields (instead of `fields: "*"`).
+- Update operations use `opType=replace` for custom property merging.
+
+---
+
 ## 1.2.0 – 2025-10-28
 
 ### Highlights

releasenotes.md

@@ -1,3 +1,29 @@
+# LogicMonitor MCP Server v2.1.1
+
+## Stdio Transport Fix
+
+Patch release that fixes a startup failure when using stdio-based MCP clients (Claude Desktop, Cursor, etc.).
+
+### Bug Fix
+
+- **Stdio stdout pollution** – Fixed a bug where Winston log output and audit log entries were written to `stdout` during server startup in stdio mode. MCP clients that read stdout exclusively for JSON-RPC messages (such as Claude Desktop) would receive non-JSON-RPC data like `{"level":"info","message":"Starting in STDIO mode","timestamp":"..."}` before the protocol handshake, causing a Zod validation error (`invalid_union` / `unrecognized_keys: ["level","message","timestamp"]`) and failing to connect.
+
+### What Changed
+
+- All Winston console transports now route to `stderr` when running in stdio mode (`--stdio`), keeping `stdout` clean for JSON-RPC.
+- The `AuditLogger` accepts a `useStderr` flag so its dedicated transport also writes to `stderr` in stdio mode.
+- The `startStdioServer()` logger is no longer restricted to `error` level — all configured log levels now flow to `stderr`, improving debuggability without polluting the protocol channel.
+
+### Upgrading from v2.1.0
+
+Drop-in replacement. No configuration or API changes.
+
+---
+
+**Full Changelog**: See [CHANGELOG.md](CHANGELOG.md) for detailed changes.
+
+---
+
 # LogicMonitor MCP Server v2.1.0
 
 ## New Resources, Smarter Responses, and LLM Eval System

src/audit/logger.ts

@@ -11,10 +11,13 @@ export class AuditLogger {
   private logger: winston.Logger;
   private enabled: boolean;
 
-  constructor(config: Config) {
+  constructor(config: Config, useStderr = false) {
     this.enabled = config.logging.auditLogEnabled;
 
-    // Create dedicated audit logger
+    const format = config.logging.format === 'simple'
+      ? winston.format.combine(winston.format.colorize(), winston.format.simple())
+      : winston.format.json();
+
     this.logger = winston.createLogger({
       level: 'info',
       format: winston.format.combine(
@@ -27,12 +30,8 @@ export class AuditLogger {
       },
       transports: [
         new winston.transports.Console({
-          format: config.logging.format === 'simple'
-            ? winston.format.combine(
-                winston.format.colorize(),
-                winston.format.simple()
-              )
-            : winston.format.json(),
+          format,
+          stderrLevels: useStderr ? ['error', 'warn', 'info', 'http', 'verbose', 'debug', 'silly'] : [],
         }),
       ],
     });

src/index.ts

@@ -19,9 +19,26 @@ import { createRateLimitMiddleware } from './middleware/rateLimit.js';
 import { AuditLogger } from './audit/logger.js';
 import { GracefulShutdown } from './utils/gracefulShutdown.js';
 
+// Detect stdio mode early — before any logging can pollute stdout.
+// In stdio mode, stdout is reserved exclusively for JSON-RPC messages.
+const isStdioMode = process.argv.includes('--stdio');
+
 // Load configuration
 const config = getConfig();
 
+// In stdio mode, ALL Winston transports must write to stderr so stdout
+// remains clean for the JSON-RPC protocol used by StdioServerTransport.
+function createStderrConsoleTransport(format: winston.Logform.Format): winston.transports.ConsoleTransportInstance {
+  return new winston.transports.Console({
+    format,
+    stderrLevels: isStdioMode ? ['error', 'warn', 'info', 'http', 'verbose', 'debug', 'silly'] : [],
+  });
+}
+
+const logFormat = config.logging.format === 'simple'
+  ? winston.format.combine(winston.format.colorize(), winston.format.simple())
+  : winston.format.json();
+
 // Set up logger
 const logger = winston.createLogger({
   level: config.logging.level,
@@ -30,20 +47,11 @@ const logger = winston.createLogger({
     winston.format.errors({ stack: true }),
     winston.format.json()
   ),
-  transports: [
-    new winston.transports.Console({
-      format: config.logging.format === 'simple'
-        ? winston.format.combine(
-            winston.format.colorize(),
-            winston.format.simple()
-          )
-        : winston.format.json()
-    })
-  ]
+  transports: [createStderrConsoleTransport(logFormat)]
 });
 
-// Initialize audit logger
-const auditLogger = new AuditLogger(config);
+// Initialize audit logger (routes to stderr in stdio mode)
+const auditLogger = new AuditLogger(config, isStdioMode);
 
 // Initialize graceful shutdown
 const gracefulShutdown = new GracefulShutdown(logger);
@@ -355,29 +363,29 @@ async function startHttpServer() {
 }
 
 async function startStdioServer() {
-  // In stdio mode, only log errors to stderr to avoid interfering with JSON-RPC
+  // In stdio mode, ALL log output must go to stderr — stdout is reserved
+  // exclusively for JSON-RPC messages by the StdioServerTransport.
   const stdioLogger = winston.createLogger({
-    level: 'error',
+    level: config.logging.level,
     format: winston.format.combine(
       winston.format.timestamp(),
       winston.format.errors({ stack: true }),
       winston.format.json()
     ),
     transports: [
       new winston.transports.Console({
-        stderrLevels: ['error'],
+        stderrLevels: ['error', 'warn', 'info', 'http', 'verbose', 'debug', 'silly'],
         format: winston.format.simple()
       })
     ]
   });
 
-  // Validate credentials
   if (!config.logicMonitor.account || !config.logicMonitor.bearerToken) {
     stdioLogger.error('STDIO mode requires LM_ACCOUNT and LM_BEARER_TOKEN environment variables');
     throw new Error('Missing required LogicMonitor credentials for STDIO mode');
   }
 
-  stdioLogger.error(`Starting STDIO mode with account: ${config.logicMonitor.account}`);
+  stdioLogger.info(`Starting STDIO mode with account: ${config.logicMonitor.account}`);
 
   const { server } = await createServer({ 
     logger: stdioLogger,
@@ -392,15 +400,14 @@ async function startStdioServer() {
 
   const transport = new StdioServerTransport();
 
-  // Register cleanup on shutdown
   gracefulShutdown.registerHandler(async () => {
-    stdioLogger.error('Closing STDIO server...');
+    stdioLogger.info('Closing STDIO server...');
     await server.close();
   });
 
   await server.connect(transport);
 
-  stdioLogger.error('STDIO server connected and ready');
+  stdioLogger.info('STDIO server connected and ready');
 }
 
 // Main entry point
@@ -415,10 +422,9 @@ async function main() {
       },
     });
 
-    // Determine which transports to start
-    const isStdioMode = process.argv.includes('--stdio') || !config.transport.enableHttp;
+    const shouldUseStdio = isStdioMode || !config.transport.enableHttp;
 
-    if (isStdioMode && config.transport.enableStdio) {
+    if (shouldUseStdio && config.transport.enableStdio) {
       logger.info('Starting in STDIO mode');
       await startStdioServer();
     } else if (config.transport.enableHttp) {