Skip to content

Commit c6943b8

Browse files
committed
OCPBUGS-77204: Override appendTo only if needed
1 parent 6aebfc5 commit c6943b8

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

frontend/public/components/utils/resource-log.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,8 @@ const LogControls: FC<LogControlsProps> = ({
214214
const [isLogTypeOpen, setIsLogTypeOpen] = useState(false);
215215
const [isOptionsOpen, setIsOptionsOpen] = useState(false);
216216

217+
const toolbarId = `resource-log-toolbar-${resource?.metadata?.name || 'unknown'}`;
218+
217219
const logTypes: Array<LogType> = [
218220
{ type: LOG_TYPE_CURRENT, text: t('Current log') },
219221
{ type: LOG_TYPE_PREVIOUS, text: t('Previous log') },
@@ -270,7 +272,7 @@ const LogControls: FC<LogControlsProps> = ({
270272
onOpenChange={(isOpen) => setIsLogTypeOpen(isOpen)}
271273
isOpen={isLogTypeOpen}
272274
popperProps={{
273-
appendTo: 'inline', // needed for fullscreen
275+
appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
274276
}}
275277
>
276278
<SelectList>
@@ -354,7 +356,7 @@ const LogControls: FC<LogControlsProps> = ({
354356
onOpenChange={setIsOptionsOpen}
355357
isOpen={isOptionsOpen}
356358
popperProps={{
357-
appendTo: 'inline', // needed for fullscreen
359+
appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
358360
}}
359361
>
360362
<SelectList>
@@ -410,7 +412,7 @@ const LogControls: FC<LogControlsProps> = ({
410412
));
411413

412414
return (
413-
<Toolbar data-test="resource-log-toolbar">
415+
<Toolbar data-test="resource-log-toolbar" id={toolbarId}>
414416
<ToolbarContent>
415417
<ToolbarGroup className="pf-v6-u-display-flex pf-v6-u-flex-direction-column pf-v6-u-flex-direction-row-on-md pf-v6-u-w-100">
416418
<ToolbarGroup align={{ default: 'alignStart' }}>

0 commit comments

Comments
 (0)