Skip to content

[logstash-input] Handle connection errors correctly #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ash-darin wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[logstash-input] Handle connection errors correctly #536

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
081895b
Update BeatsHandler.java
ash-darin Apr 14, 2026
30bcf77
Remove unused logging
ash-darin Apr 14, 2026
8358ee6
Update warning message
ash-darin Apr 14, 2026
e0cea51
Reorder checks as suggested
ash-darin Apr 17, 2026
e23cfc2
revert to original handling.
ash-darin Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/main/java/org/logstash/beats/BeatsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,23 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
}
} else {
final Throwable realCause = extractCause(cause, 0);
if (logger.isDebugEnabled()) {
Comment thread
ash-darin marked this conversation as resolved.
logger.info(format("Handling exception: " + cause + " (caused by: " + realCause + ")"), cause);
} else {
logger.info(format("Handling exception: " + cause + " (caused by: " + realCause + ")"));
}
// when execution tasks rejected, no need to forward the exception to netty channel handlers
if (cause instanceof RejectedExecutionException) {
if (logger.isDebugEnabled()) {
Comment thread
ash-darin marked this conversation as resolved.
logger.info(format("Handling exception: " + cause + " (caused by: " + realCause + ")"), cause);
} else {
logger.info(format("Handling exception: " + cause + " (caused by: " + realCause + ")"));
}
// we no longer have event executors available since they are terminated, mostly by shutdown process
if (Objects.nonNull(cause.getMessage()) && cause.getMessage().contains(executorTerminatedMessage)) {
this.isQuietPeriod.compareAndSet(false, true);
}
} else {
if (logger.isDebugEnabled()) {
Comment thread
ash-darin marked this conversation as resolved.
logger.warn(format("Unhandled exception: " + cause + " (caused by: " + realCause + ")"), cause);
} else {
logger.warn(format("Unhandled exception: " + cause + " (caused by: " + realCause + ")"));
}
super.exceptionCaught(ctx, cause);
}
}
Expand Down