Update redis.rb#63
Open
ewatremetz wants to merge 1 commit into
Open
Conversation
gestion du redis set
robbavey
requested changes
Oct 11, 2019
robbavey
left a comment
robbavey
left a comment
Member
There was a problem hiding this comment.
@ewatremetz - currently, this PR does not build correctly. Also, this PR is missing tests (and ideally documentation updates).
Thanks!
| else | ||
| @redis.publish(key, payload) | ||
| end | ||
| # gestion du set |
Member
There was a problem hiding this comment.
I'm not sure what this comment means
| @redis.publish(key, payload) | ||
| end | ||
| # gestion du set | ||
| @redis ||= connect |
Member
There was a problem hiding this comment.
Indentation has gone awry here.
| @redis.publish(key, payload) | ||
| else | ||
| @redis.set(key, payload) | ||
| end |
Member
There was a problem hiding this comment.
As it stands, this PR does not compile, due to a missing end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gestion du redis set
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/