Unused removal #2 (#1183)

* Remove 12 confirmed dead code items

Store fields:
- HistoryStore.sshCmds (never accessed)
- HistoryStore.writeScriptTipShown (never accessed)
- SettingStore.storeVersion (never read/written)

Provider:
- PveNotifier.onlyOneNode (model getter used instead)

Enum values:
- SSHErrType.chdir (never instantiated)
- ContainerErrType.cmdNoPrefix (never referenced)
- SystemdUnitFunc.reload, .enable, .disable (never used)

Extensions/methods:
- SshDiscoveryConfigX.toArgs() (never called)
- ChainComparator.empty() (create() used instead)
- PortForwardStore.update/have/deleteByServer (never called)

Constants:
- Miscs.maxDebugLogLines (never referenced)

Other:
- SensorAdaptor static instances inlined in parse()
- Updated tests to match

* Remove 4 unused model fields

NvidiaSmiItem.uuid:
- Parsed from nvidia-smi XML but never read in UI or logic

AmdSmiItem.deviceId:
- Parsed from amd-smi JSON but never read in UI or logic

Conn.active, Conn.passive:
- Parsed from /proc/net/snmp but only maxConn and fail
  are displayed in the connection stats view

Windows connCount moved from active to maxConn field
since that is the field actually shown in the UI.

* Deduplicate repeated code patterns

C1: Replace local _shellQuote in sftp.dart and sftp_sudo.dart
    with canonical shellSingleQuote from shell_quote.dart

C2: Replace _formatSize in connection_stats.dart with
    existing bytes2Str extension from fl_lib

C3: Extract _parseFirstInt helper in nvdia.dart to replace
    6 instances of int.tryParse(s?.split(' ').firstOrNull ?? '0') ?? 0

C4: Extract _updateDiskUsage helper in server_status_update_req.dart
    to deduplicate DiskUsage.parse guard pattern in Linux and BSD paths

* Performance: cache Proc.binary, optimize NetSpeed iteration

D1: Proc.binary getter re-parsed command string on every access
(called O(n log n) times during sort). Changed to late final
field so it is computed once per Proc instance.

D3: NetSpeed speedIn/sizeIn/speedOut/sizeOut used
devices.indexOf(device) inside loops (O(n) per iteration).
Replaced with index-based iteration for O(1) per iteration.
Also optimized deviceIdx to use direct index comparison
instead of iterating then calling indexOf.

D2 skipped: ref.listen in build() is correct Riverpod pattern
(Riverpod deduplicates listeners by identity).

* Fix prefix double-counting in NetSpeed, fix shell injection in SFTP edit

NetSpeed: realIfacePrefixs contains both 'wl' and 'wlan', so a device
like wlan0 matched both prefixes and was counted twice. Added break
after first prefix match in all 4 aggregation methods (speedIn,
sizeIn, speedOut, sizeOut).

SFTP edit: remotePath was wrapped with manual single quotes which
doesn't escape embedded single quotes. Replaced with
shellSingleQuote(remotePath) for proper escaping.

Author: GT-610

lib/core/utils/comparator.dart

@@ -3,7 +3,6 @@ class ChainComparator<T> {
   final Comparator<T> _comparator;
 
   ChainComparator._create(this._parent, this._comparator);
-  ChainComparator.empty() : this._create(null, (a, b) => 0);
   ChainComparator.create() : this._create(null, (a, b) => 0);
 
   static ChainComparator<T> comparing<T, F extends Comparable<F>>(

lib/core/utils/sftp_sudo.dart

@@ -6,6 +6,7 @@ import 'package:fl_lib/fl_lib.dart';
 import 'package:flutter/material.dart';
 import 'package:server_box/core/extension/context/locale.dart';
 import 'package:server_box/core/extension/ssh_client.dart';
+import 'package:server_box/core/utils/shell_quote.dart';
 import 'package:server_box/data/model/server/server_private_info.dart';
 import 'package:server_box/data/res/store.dart';
 
@@ -55,7 +56,7 @@ final class SftpSudoHelper {
 
   Future<int> getFileSize(String remotePath, {String? password}) async {
     final output = await _runAndRead(
-      'wc -c < ${_shellQuote(remotePath)}',
+      'wc -c < ${shellSingleQuote(remotePath)}',
       password: password,
     );
     return int.tryParse(output.trim()) ?? 0;
@@ -67,7 +68,7 @@ final class SftpSudoHelper {
     String? password,
   }) async {
     final text = await _runAndRead(
-      'cat ${_shellQuote(remotePath)}',
+      'cat ${shellSingleQuote(remotePath)}',
       password: password,
     );
     final file = File(localPath);
@@ -84,7 +85,7 @@ final class SftpSudoHelper {
     final bytes = await file.readAsBytes();
     final data = base64Encode(bytes);
     await _runAndRead(
-      "printf '%s' '$data' | base64 -d | tee ${_shellQuote(remotePath)} > /dev/null",
+      "printf '%s' '$data' | base64 -d | tee ${shellSingleQuote(remotePath)} > /dev/null",
       password: password,
     );
   }
@@ -98,17 +99,17 @@ final class SftpSudoHelper {
       );
     }
     await _runAndRead(
-      'chmod $perm ${_shellQuote(remotePath)}',
+      'chmod $perm ${shellSingleQuote(remotePath)}',
       password: password,
     );
   }
 
   Future<void> mkdir(String remotePath, {String? password}) async {
-    await _runAndRead('mkdir ${_shellQuote(remotePath)}', password: password);
+    await _runAndRead('mkdir ${shellSingleQuote(remotePath)}', password: password);
   }
 
   Future<void> touch(String remotePath, {String? password}) async {
-    await _runAndRead('touch ${_shellQuote(remotePath)}', password: password);
+    await _runAndRead('touch ${shellSingleQuote(remotePath)}', password: password);
   }
 
   Future<void> rename(
@@ -117,7 +118,7 @@ final class SftpSudoHelper {
     String? password,
   }) async {
     await _runAndRead(
-      'mv ${_shellQuote(oldPath)} ${_shellQuote(newPath)}',
+      'mv ${shellSingleQuote(oldPath)} ${shellSingleQuote(newPath)}',
       password: password,
     );
   }
@@ -129,16 +130,16 @@ final class SftpSudoHelper {
     String? password,
   }) async {
     final cmd = switch ((isDir, recursive)) {
-      (true, true) => 'rm -r ${_shellQuote(remotePath)}',
-      (true, false) => 'rmdir ${_shellQuote(remotePath)}',
-      (false, _) => 'rm ${_shellQuote(remotePath)}',
+      (true, true) => 'rm -r ${shellSingleQuote(remotePath)}',
+      (true, false) => 'rmdir ${shellSingleQuote(remotePath)}',
+      (false, _) => 'rm ${shellSingleQuote(remotePath)}',
     };
     await _runAndRead(cmd, password: password);
   }
 
   Future<List<SftpName>> listDir(String remotePath, {String? password}) async {
     final output = await _runAndRead(
-      'find ${_shellQuote(remotePath)} '
+      'find ${shellSingleQuote(remotePath)} '
       '-mindepth 1 -maxdepth 1 '
       '-exec sh -c \''
       'for path do '
@@ -242,10 +243,6 @@ final class SftpSudoHelper {
     return 'echo "$pwdBase64" | base64 -d | sudo -S -- sh -c \'$escapedWrapped\'';
   }
 
-  static String _shellQuote(String value) {
-    return "'${value.replaceAll("'", "'\\''")}'";
-  }
-
   static SftpFileMode _buildMode(String typeChar, int permOct) {
     final typeFlag = switch (typeChar) {
       'd' => 0x4000,

lib/data/model/app/error.dart

@@ -6,7 +6,6 @@ enum SSHErrType {
   connect,
   auth,
   noPrivateKey,
-  chdir,
   segements,
   writeScript,
   getStatus,
@@ -17,7 +16,6 @@ class SSHErr extends Err<SSHErrType> {
 
   @override
   String? get solution => switch (type) {
-    SSHErrType.chdir => l10n.needHomeDir,
     SSHErrType.auth => l10n.authFailTip,
     SSHErrType.writeScript => l10n.writeScriptFailTip,
     SSHErrType.noPrivateKey => l10n.noPrivateKeyTip,
@@ -30,7 +28,6 @@ enum ContainerErrType {
   noClient,
   notInstalled,
   invalidVersion,
-  cmdNoPrefix,
   segmentsNotMatch,
   parsePs,
   parseImages,

lib/data/model/server/amd.dart

@@ -50,8 +50,6 @@ class AmdSmi {
           gpu['card_model'] ??
           gpu['device_name'] ??
           'Unknown AMD GPU';
-      final deviceId =
-          gpu['device_id']?.toString() ?? gpu['gpu_id']?.toString() ?? '0';
 
       // Temperature parsing
       final tempRaw = gpu['temperature'] ?? gpu['temp'] ?? gpu['gpu_temp'];
@@ -80,7 +78,6 @@ class AmdSmi {
       );
 
       return AmdSmiItem(
-        deviceId: deviceId,
         name: name,
         temp: temp,
         power: power,
@@ -149,7 +146,6 @@ class AmdSmi {
 }
 
 class AmdSmiItem {
-  final String deviceId;
   final String name;
   final int temp;
   final String power;
@@ -159,7 +155,6 @@ class AmdSmiItem {
   final int clockSpeed;
 
   const AmdSmiItem({
-    required this.deviceId,
     required this.name,
     required this.temp,
     required this.power,

lib/data/model/server/conn.dart

@@ -2,14 +2,10 @@ import 'package:server_box/data/res/misc.dart';
 
 class Conn {
   final int maxConn;
-  final int active;
-  final int passive;
   final int fail;
 
   const Conn({
     required this.maxConn,
-    required this.active,
-    required this.passive,
     required this.fail,
   });
 
@@ -23,8 +19,6 @@ class Conn {
       final vals = idx.split(Miscs.blankReg);
       return Conn(
         maxConn: int.tryParse(vals[5]) ?? 0,
-        active: int.tryParse(vals[6]) ?? 0,
-        passive: int.tryParse(vals[7]) ?? 0,
         fail: int.tryParse(vals[8]) ?? 0,
       );
     }

lib/data/model/server/discovery_result.dart

@@ -38,14 +38,3 @@ abstract class SshDiscoveryConfig with _$SshDiscoveryConfig {
     @Default(4096) int hostEnumerationLimit,
   }) = _SshDiscoveryConfig;
 }
-
-extension SshDiscoveryConfigX on SshDiscoveryConfig {
-  List<String> toArgs() {
-    final args = <String>[];
-    args.add('--timeout-ms=$timeoutMs');
-    args.add('--max-concurrency=$maxConcurrency');
-    args.add('--host-enumeration-limit=$hostEnumerationLimit');
-    if (enableMdns) args.add('--enable-mdns');
-    return args;
-  }
-}

lib/data/model/server/net_speed.dart

@@ -82,10 +82,11 @@ class NetSpeed extends TimeSeq<NetSpeedPart> {
     if (pre.length != now.length) return 'N/A';
     if (device == null) {
       var speed = 0.0;
-      for (final device in devices) {
+      for (var i = 0; i < devices.length; i++) {
         for (final prefix in realIfacePrefixs) {
-          if (device.startsWith(prefix)) {
-            speed += speedInBytes(devices.indexOf(device));
+          if (devices[i].startsWith(prefix)) {
+            speed += speedInBytes(i);
+            break;
           }
         }
       }
@@ -100,10 +101,11 @@ class NetSpeed extends TimeSeq<NetSpeedPart> {
     if (pre.length != now.length) return 'N/A';
     if (device == null) {
       var size = BigInt.from(0);
-      for (final device in devices) {
+      for (var i = 0; i < devices.length; i++) {
         for (final prefix in realIfacePrefixs) {
-          if (device.startsWith(prefix)) {
-            size += sizeInBytes(devices.indexOf(device));
+          if (devices[i].startsWith(prefix)) {
+            size += sizeInBytes(i);
+            break;
           }
         }
       }
@@ -118,10 +120,11 @@ class NetSpeed extends TimeSeq<NetSpeedPart> {
     if (pre.length != now.length) return 'N/A';
     if (device == null) {
       var speed = 0.0;
-      for (final device in devices) {
+      for (var i = 0; i < devices.length; i++) {
         for (final prefix in realIfacePrefixs) {
-          if (device.startsWith(prefix)) {
-            speed += speedOutBytes(devices.indexOf(device));
+          if (devices[i].startsWith(prefix)) {
+            speed += speedOutBytes(i);
+            break;
           }
         }
       }
@@ -136,10 +139,11 @@ class NetSpeed extends TimeSeq<NetSpeedPart> {
     if (pre.length != now.length) return 'N/A';
     if (device == null) {
       var size = BigInt.from(0);
-      for (final device in devices) {
+      for (var i = 0; i < devices.length; i++) {
         for (final prefix in realIfacePrefixs) {
-          if (device.startsWith(prefix)) {
-            size += sizeOutBytes(devices.indexOf(device));
+          if (devices[i].startsWith(prefix)) {
+            size += sizeOutBytes(i);
+            break;
           }
         }
       }
@@ -151,10 +155,8 @@ class NetSpeed extends TimeSeq<NetSpeedPart> {
 
   int deviceIdx(String? device) {
     if (device != null) {
-      for (var item in now) {
-        if (item.device == device) {
-          return now.indexOf(item);
-        }
+      for (var i = 0; i < now.length; i++) {
+        if (now[i].device == device) return i;
       }
     }
     return 0;

lib/data/model/server/nvdia.dart

@@ -1,5 +1,8 @@
 import 'package:xml/xml.dart';
 
+int _parseFirstInt(String? s) =>
+    int.tryParse(s?.split(' ').firstOrNull ?? '0') ?? 0;
+
 /// [
 ///   {
 ///     "name": "GeForce RTX 3090",
@@ -67,7 +70,7 @@ class NvidiaSmi {
             return NvidiaSmiMemProcess(
               int.tryParse(pid) ?? 0,
               name,
-              int.tryParse(memory.split(' ').firstOrNull ?? '0') ?? 0,
+              _parseFirstInt(memory),
             );
           }
           return null;
@@ -84,17 +87,16 @@ class NvidiaSmi {
       if (name != null && temp != null) {
         return NvidiaSmiItem(
           name: name,
-          uuid: gpu.findElements('uuid').firstOrNull?.innerText ?? '',
-          temp: int.tryParse(temp.split(' ').firstOrNull ?? '0') ?? 0,
-          percent: int.tryParse(percent?.split(' ').firstOrNull ?? '0') ?? 0,
+          temp: _parseFirstInt(temp),
+          percent: _parseFirstInt(percent),
           power: '$powerDraw / $powerLimit',
           memory: NvidiaSmiMem(
-            int.tryParse(memoryTotal?.split(' ').firstOrNull ?? '0') ?? 0,
-            int.tryParse(memoryUsed?.split(' ').firstOrNull ?? '0') ?? 0,
+            _parseFirstInt(memoryTotal),
+            _parseFirstInt(memoryUsed),
             'MiB',
             List.from(memoryProcesses),
           ),
-          fanSpeed: int.tryParse(fanSpeed?.split(' ').firstOrNull ?? '0') ?? 0,
+          fanSpeed: _parseFirstInt(fanSpeed),
         );
       }
       return null;
@@ -105,7 +107,6 @@ class NvidiaSmi {
 }
 
 class NvidiaSmiItem {
-  final String uuid;
   final String name;
   final int temp;
   final String power;
@@ -114,7 +115,6 @@ class NvidiaSmiItem {
   final int fanSpeed;
 
   const NvidiaSmiItem({
-    required this.uuid,
     required this.name,
     required this.temp,
     required this.power,

lib/data/model/server/proc.dart

@@ -52,7 +52,9 @@ class Proc {
   final double? writeSpeed;
   final String command;
 
-  const Proc({
+  late final binary = _parseBinary();
+
+  Proc({
     this.user,
     required this.pid,
     this.cpu,
@@ -162,7 +164,7 @@ class Proc {
     return Miscs.jsonEncoder.convert(toJson());
   }
 
-  String get binary {
+  String _parseBinary() {
     final parts = command.trim().split(' ').where((e) => e.isNotEmpty).toList();
     return parts.isNotEmpty ? parts[0] : '';
   }

lib/data/model/server/sensors.dart

@@ -9,16 +9,11 @@ final class SensorAdaptor {
   static const pciRaw = 'PCI adapter';
   static const virtualRaw = 'Virtual device';
   static const isaRaw = 'ISA adapter';
-  static const acpi = SensorAdaptor(acpiRaw);
-  static const pci = SensorAdaptor(pciRaw);
-  static const virtual = SensorAdaptor(virtualRaw);
-  static const isa = SensorAdaptor(isaRaw);
-
   static SensorAdaptor parse(String raw) => switch (raw) {
-    acpiRaw => acpi,
-    pciRaw => pci,
-    virtualRaw => virtual,
-    isaRaw => isa,
+    acpiRaw => const SensorAdaptor(acpiRaw),
+    pciRaw => const SensorAdaptor(pciRaw),
+    virtualRaw => const SensorAdaptor(virtualRaw),
+    isaRaw => const SensorAdaptor(isaRaw),
     _ => SensorAdaptor(raw),
   };
 }