Skip to content

Fix intro flow home window frame wrapping#1136

Merged
GT-610 merged 1 commit into
mainfrom
fix-hideden-titlebar-on-unix-systems
Apr 24, 2026
Merged

Fix intro flow home window frame wrapping#1136
GT-610 merged 1 commit into
mainfrom
fix-hideden-titlebar-on-unix-systems

Conversation

@GT-610
Copy link
Copy Markdown
Collaborator

@GT-610 GT-610 commented Apr 24, 2026

Resolve #1132 .

Summary

  • Reuse a shared VirtualWindowFrame wrapper for the home page.
  • Ensure the intro completion path enters the same wrapped home route as normal startup.
  • Prevent first-launch title bar overlap on macOS and affected Linux desktops.

Testing

  • Verified with targeted Dart analysis on lib/app.dart, lib/intro.dart, and lib/view/page/home.dart.
  • Confirmed the analyzer reports no issues for the changed code path.

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue where the application window frame could be duplicated during navigation, particularly after completing the introduction sequence. This ensures consistent presentation across all navigation paths.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a785ae62-ad96-41da-ae5e-df2af516bd6e

📥 Commits

Reviewing files that changed from the base of the PR and between 5443ef4 and d0aaf82.

📒 Files selected for processing (2)
  • lib/app.dart
  • lib/intro.dart

📝 Walkthrough

Walkthrough

The changes refactor home page initialization by introducing a helper function that wraps the home page in a VirtualWindowFrame. A new flag prevents duplicate frame application. The navigation flow after intro completion is updated to use this new helper instead of directly instantiating the home page widget. These modifications standardize the windowing behavior across different initialization paths while maintaining existing intro-page rendering logic.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing intro flow to properly wrap home page with VirtualWindowFrame, addressing the window frame wrapping issue on first launch.
Linked Issues check ✅ Passed Changes implement the required fix for issue #1132 by ensuring consistent VirtualWindowFrame wrapping for home page across both normal startup and intro completion paths, resolving the title bar overlap issue.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the objective of fixing intro flow home window frame wrapping to address the macOS title bar overlap issue; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-hideden-titlebar-on-unix-systems

Comment @coderabbitai help to get the list of available commands and usage tips.

@GT-610 GT-610 marked this pull request as ready for review April 24, 2026 08:05
@GT-610 GT-610 merged commit c1ccc09 into main Apr 24, 2026
1 check passed
@GT-610 GT-610 deleted the fix-hideden-titlebar-on-unix-systems branch April 24, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS主页面UI有问题

1 participant