Skip to content

Pin Flutter version to 3.41.9 as 3.44 have compatibility issues#1177

Merged
GT-610 merged 1 commit into
mainfrom
pin-flutter-version
May 22, 2026
Merged

Pin Flutter version to 3.41.9 as 3.44 have compatibility issues#1177
GT-610 merged 1 commit into
mainfrom
pin-flutter-version

Conversation

@GT-610
Copy link
Copy Markdown
Collaborator

@GT-610 GT-610 commented May 22, 2026

The compilation issues with upstream third-party dependencies in Flutter 3.44 are not caused by ServerBox code:
The various IconData subclasses in icons_plus: ^5.0.0 (such as AntDesignIconData and BootstrapIconData) extend the final class IconData in Flutter 3.44, which causes a compilation error.
re_editor: Version ^0.8.0 does not implement the TextInputClient.onFocusReceived() method introduced in Flutter 3.44, which also causes a compilation failure.

Until these issues are resolved, Flutter version is temporary locked at 3.41.9 and consider migrating later based on the status of the upstream packages.

Summary by CodeRabbit

  • Chores
    • Updated continuous integration and testing infrastructure to use the latest compatible Flutter version, ensuring improved build reliability and consistency across all automated testing environments.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

📝 Walkthrough

Walkthrough

This pull request updates the Flutter SDK version pinning across GitHub Actions CI workflows. The analysis workflow now pins Flutter to version 3.41.9, and the build workflow updates Android from 3.41.4 to 3.41.9 while setting Linux and Windows jobs to use Flutter 3.41.9 on the stable channel. These changes standardize the Flutter toolchain version across all CI jobs.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: pinning Flutter version to 3.41.9 due to compatibility issues with version 3.44, which matches the changeset modifications to workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pin-flutter-version

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/analysis.yml:
- Line 27: The workflow currently pins flutter-version: '3.41.9' but that tag
isn’t present in the flutter/flutter GitHub releases; update the CI step that
sets flutter-version (the flutter-version field in the job using setup-flutter)
to either use the exact SDK archive reference supported by the action (e.g., the
archive name or channel+version syntax that setup-flutter accepts) or add a
short comment clarifying that '3.41.9' is pulled from the official Flutter SDK
archive (not GitHub tags) so future maintainers know this is intentional; locate
the job that contains the flutter-version key to apply the change (the
flutter-version entry shown in the .github/workflows/analysis.yml diff).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2d771795-7307-4812-8513-b56f58103980

📥 Commits

Reviewing files that changed from the base of the PR and between c57be23 and b0b9f91.

📒 Files selected for processing (2)
  • .github/workflows/analysis.yml
  • .github/workflows/build.yml

Comment thread .github/workflows/analysis.yml
@GT-610
Copy link
Copy Markdown
Collaborator Author

GT-610 commented May 22, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@GT-610
Copy link
Copy Markdown
Collaborator Author

GT-610 commented May 22, 2026

@coderabbitai help

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai rate limit to show your current review rate limit status.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
  • @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
  • @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai emit path instructions to emit generated path-specific review instructions for this repository.
  • @coderabbitai resolve merge conflict to automatically resolve merge conflicts.
  • @coderabbitai autofix to automatically fix issues identified in unresolved review comments.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit configuration file (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, support, documentation and community

  • Visit our status page to check the current availability of CodeRabbit.
  • Create a ticket on our support page for assistance with any issues or questions.
  • Visit our documentation site for detailed information on how to use CodeRabbit.
  • Join our Discord community to connect with other users and get help from the community.
  • Follow us on X/Twitter for updates and announcements.

@GT-610 GT-610 merged commit e52ef43 into main May 22, 2026
3 checks passed
@GT-610 GT-610 deleted the pin-flutter-version branch May 22, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant