Pin Flutter version to 3.41.9 as 3.44 have compatibility issues#1177
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Flutter SDK version pinning across GitHub Actions CI workflows. The analysis workflow now pins Flutter to version 3.41.9, and the build workflow updates Android from 3.41.4 to 3.41.9 while setting Linux and Windows jobs to use Flutter 3.41.9 on the stable channel. These changes standardize the Flutter toolchain version across all CI jobs. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/analysis.yml:
- Line 27: The workflow currently pins flutter-version: '3.41.9' but that tag
isn’t present in the flutter/flutter GitHub releases; update the CI step that
sets flutter-version (the flutter-version field in the job using setup-flutter)
to either use the exact SDK archive reference supported by the action (e.g., the
archive name or channel+version syntax that setup-flutter accepts) or add a
short comment clarifying that '3.41.9' is pulled from the official Flutter SDK
archive (not GitHub tags) so future maintainers know this is intentional; locate
the job that contains the flutter-version key to apply the change (the
flutter-version entry shown in the .github/workflows/analysis.yml diff).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2d771795-7307-4812-8513-b56f58103980
📒 Files selected for processing (2)
.github/workflows/analysis.yml.github/workflows/build.yml
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
The compilation issues with upstream third-party dependencies in Flutter 3.44 are not caused by ServerBox code:
The various IconData subclasses in
icons_plus: ^5.0.0(such asAntDesignIconDataandBootstrapIconData) extend thefinal class IconDatain Flutter 3.44, which causes a compilation error.re_editor: Version ^0.8.0 does not implement the TextInputClient.onFocusReceived() method introduced in Flutter 3.44, which also causes a compilation failure.
Until these issues are resolved, Flutter version is temporary locked at 3.41.9 and consider migrating later based on the status of the upstream packages.
Summary by CodeRabbit