fix(ssh): Windows IME candidate window text not sent to terminal by LittleWool · Pull Request #1235 · lollipopkit/flutter_server_box

LittleWool · 2026-07-19T09:00:40Z

Fix Windows IME candidate window text not sent to terminal.

Problem

On Windows, when using an IME (e.g., Microsoft Pinyin, Sogou), text selected from the candidate window is not sent to the terminal.

Root Cause

updateEditingValue in xterm's custom_text_edit.dart incorrectly computes text deltas from the previous composing text length. When IME composing ends and commits text of a different length (e.g., "ni" → "你"), the code misinterprets it as a deletion.

Changes

Update xterm submodule to LittleWool/xterm.dart fix/windows-ime-input branch which contains the fix
See xterm.dart PR 请问这个会在服务器上安装探针之类的东东吗？ #11 for the actual code change

Testing

Build Windows version and test with Microsoft Pinyin IME
Committed text from candidate window should now appear in the terminal

Summary by CodeRabbit

Chores
- Updated the bundled terminal component to point to a new upstream source and branch.
- Refreshed the included terminal submodule to a newer revision.
- No visible user-facing changes expected.

coderabbitai · 2026-07-19T09:01:11Z

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 648dbbf5-4ef6-40e7-bd87-87377cfbc605

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

📝 Walkthrough

Walkthrough

Updated the xterm submodule configuration to use a new repository URL and track the fix/windows-ime-input branch, while advancing the submodule pointer to a new commit and keeping the path unchanged.

Possibly related PRs

lollipopkit/flutter_server_box#1051: Updates the packages/xterm submodule pointer.

Suggested reviewers: lollipopkit

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: fixing Windows IME candidate text not being sent to the terminal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

This PR aims to fix Windows IME committed text not being sent to the terminal by switching the packages/xterm submodule to a fork/branch that contains the upstream fix.

Changes:

Point xterm submodule remote from lollipopkit/xterm.dart to LittleWool/xterm.dart.
Set the xterm submodule branch to fix/windows-ime-input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.gitmodules:
- Around line 7-8: Update the packages/xterm gitlink to record the commit
containing the Windows IME fix, in addition to the .gitmodules fetch target
change. Ensure the submodule SHA points to the intended fix/windows-ime-input
revision so normal checkouts retrieve the fix.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e3b4cca2-9125-4ac3-9ebf-2dbf629b09fd

📥 Commits

Reviewing files that changed from the base of the PR and between 70e3c44 and f27aae6.

📒 Files selected for processing (1)

.gitmodules

LittleWool · 2026-07-21T15:09:16Z

Review feedback addressed in c3218f1a:

updated the recorded packages/xterm gitlink to 2b3774232dcadd1458e648a14dd8c6475de95915
the referenced xterm commit includes the Windows IME fix and shorter/longer commit-transition regression tests
fresh recursive checkouts now retrieve the intended fixed revision

All existing review threads have been replied to and resolved. @coderabbitai review

coderabbitai · 2026-07-21T15:09:26Z

@LittleWool Thanks for the update. I’ll review the revised xterm submodule reference and configuration, including the resolved feedback.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chore(xterm): update submodule to fix Windows IME candidate input

f27aae6

Copilot AI review requested due to automatic review settings July 19, 2026 09:00

Copilot started reviewing on behalf of LittleWool July 19, 2026 09:01 View session

Copilot AI reviewed Jul 19, 2026

View reviewed changes

Comment thread .gitmodules

coderabbitai Bot requested changes Jul 19, 2026

View reviewed changes

Comment thread .gitmodules

fix: pin xterm Windows IME fix

c3218f1

coderabbitai Bot requested a review from lollipopkit July 21, 2026 15:08

coderabbitai Bot approved these changes Jul 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ssh): Windows IME candidate window text not sent to terminal#1235

fix(ssh): Windows IME candidate window text not sent to terminal#1235
LittleWool wants to merge 2 commits into
lollipopkit:mainfrom
LittleWool:fix/windows-ime-input

LittleWool commented Jul 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 19, 2026 •

edited

Loading

Review skipped

Walkthrough

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

LittleWool commented Jul 21, 2026

Uh oh!

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

LittleWool commented Jul 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Changes

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LittleWool commented Jul 21, 2026

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LittleWool commented Jul 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 19, 2026 •

edited

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading