Ensure finalizer safety

Removed finalizer from VmmSearch since there isn't a good way to avoid touching managed objects in the finalizer. It is up to the API Consumer to ensure calling Dispose.
[no ci]

Author: lone7254

src/VmmSharpEx/LeechCore.cs

@@ -167,10 +167,7 @@ public override string ToString()
         }
     }
 
-    ~LeechCore()
-    {
-        Dispose(false);
-    }
+    ~LeechCore() => Dispose(disposing: false);
 
     private void Dispose(bool disposing)
     {
@@ -560,7 +557,7 @@ private unsafe void Dispose(bool disposing)
             }
         }
 
-        ~LcScatterHandle() => Dispose(false);
+        ~LcScatterHandle() => Dispose(disposing: false);
 
         #endregion
     }

src/VmmSharpEx/Vmm.cs

@@ -169,10 +169,7 @@ public Vmm(params string[] args)
     /// <summary>
     /// Finalizer to ensure the native handle is closed if <see cref="Dispose()"/> was not called.
     /// </summary>
-    ~Vmm()
-    {
-        Dispose(false);
-    }
+    ~Vmm() => Dispose(disposing: false);
 
     /// <inheritdoc />
     public void Dispose()
@@ -192,9 +189,12 @@ private void Dispose(bool disposing)
     {
         if (Interlocked.Exchange(ref _handle, IntPtr.Zero) is IntPtr h && h != IntPtr.Zero)
         {
-            LeechCore?.Dispose();
+            if (disposing)
+            {
+                LeechCore.Dispose();
+                RefreshManager.UnregisterAll(this);
+            }
             Vmmi.VMMDLL_Close(h);
-            RefreshManager.UnregisterAll(this);
         }
     }
 

src/VmmSharpEx/VmmSearch.cs

@@ -25,6 +25,9 @@ namespace VmmSharpEx;
 /// <summary>
 /// VmmSearch represents a binary search in memory.
 /// </summary>
+/// <remarks>
+/// Failure to call <see cref="Dispose"/> will result in native memory leaks.
+/// </remarks>
 public sealed class VmmSearch : IDisposable
 {
     private readonly SearchContext _managed = new();
@@ -246,24 +249,14 @@ private bool SearchResultCallback(Vmmi.VMMDLL_MEM_SEARCH_CONTEXT ctx, ulong va,
     /// <summary>
     /// Aborts the search if it is still running and cleans up resources.
     /// </summary>
-    public void Dispose()
-    {
-        Dispose(disposing: true);
-        GC.SuppressFinalize(this);
-    }
-
-    private unsafe void Dispose(bool disposing)
+    public unsafe void Dispose()
     {
         if (Interlocked.Exchange(ref _disposed, true) == false)
         {
-            if (disposing)
-            {
-                Completed = null;
-            }
+            Completed = null;
             if (_worker is null || _worker.IsCompleted)
             {
-                NativeMemory.Free(_native);
-                _native = null;
+                FreeInternal();
             }
             else // Still running
             {
@@ -276,15 +269,21 @@ private unsafe void Dispose(bool disposing)
                     }
                     finally
                     {
-                        NativeMemory.Free(_native);
-                        _native = null;
+                        FreeInternal();
                     }
                 });
             }
         }
     }
 
-    ~VmmSearch() => Dispose(disposing: false);
+    private unsafe void FreeInternal()
+    {
+        if (_native != null)
+        {
+            NativeMemory.Free(_native);
+            _native = null;
+        }
+    }
 
     /// <summary>
     /// Struct with info about the current search results.