Dropdowns have touching elements with hover/backrounds

[disconnectedgrinders]

I want to make it clear im not familiar with coding and therefore cannot contribute code myself, but I noticed that in dropdowns that if one element is selected and the other is hoverd they touch. This is normaly fine but as these have a border radius the common rule is that they should have spacing. I suggest something like a 4px spacing would be sufficent.

If I'm submiting this wrong please inform me as again I'm not familar with this and only noticed this as I use a service that use gpui.

[lurenjia534]

@madcodelife @huacnlee
Do you want me to handle this?
Hi, I took a look at the implementation and it seems there are two possible fixes:

1. Increase the vertical gap between popup menu items, for example from gap_y_0p5() to gap_y_1(). This is the smallest change, but it slightly increases the overall menu height.
2. Keep the current menu density and render the hover/selected background as an inset layer inside MenuItemElement. This preserves spacing, but is a bit more involved.

Do you have a preference for which direction would be more acceptable before I open a PR?

[madcodelife]

@lurenjia534 Thanks for taking the time to file this, but we don't see this as an issue. By design for now.

[lurenjia534]

@lurenjia534 Thanks for taking the time to file this, but we don't see this as an issue. By design for now.

Got it, thanks for clarifying.