Skip to content

[WIP] Update argument style and revert specific changes in PR #1343#1344

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/restore-argument-style-and-formatting
Closed

[WIP] Update argument style and revert specific changes in PR #1343#1344
Copilot wants to merge 1 commit into
mainfrom
copilot/restore-argument-style-and-formatting

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 10, 2025

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Apply the following code review directions to PR #1343 in longbridge/gpui-component:

  1. Restore argument style to use &mut Window, &mut App everywhere, as this is the standard in the GPUI application and should not be refactored away.
  2. Where the type Self was used, change it to Root instead, per review comment.
  3. For function/method argument formatting, always keep the original style where possible, not introducing new formatting.
  4. In all locations marked with "Revert this" or similar (including "Downcast or like this, I'd like revert"), undo those changes and restore the previous logic before the PR.
  5. For improvements noted positively (e.g. "This is good, now code is shorter"), keep those changes.
  6. For any unmarked areas, follow the above style: preserve original conventions, prioritize clarity, and maintain consistency with the GPUI application's standards.

All changes must strictly adhere to the above code review feedback and style.

This pull request was created as a result of the following prompt from Copilot chat.

Apply the following code review directions to PR #1343 in longbridge/gpui-component:

  1. Restore argument style to use &mut Window, &mut App everywhere, as this is the standard in the GPUI application and should not be refactored away.
  2. Where the type Self was used, change it to Root instead, per review comment.
  3. For function/method argument formatting, always keep the original style where possible, not introducing new formatting.
  4. In all locations marked with "Revert this" or similar (including "Downcast or like this, I'd like revert"), undo those changes and restore the previous logic before the PR.
  5. For improvements noted positively (e.g. "This is good, now code is shorter"), keep those changes.
  6. For any unmarked areas, follow the above style: preserve original conventions, prioritize clarity, and maintain consistency with the GPUI application's standards.

All changes must strictly adhere to the above code review feedback and style.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@huacnlee huacnlee closed this Oct 10, 2025
Copilot AI requested a review from huacnlee October 10, 2025 01:57
@huacnlee huacnlee deleted the copilot/restore-argument-style-and-formatting branch October 10, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants