root: Add bordered option for layer-shell fullscreen windows#2466
Merged
Conversation
Add `Root::borderless()` so that layer-shell fullscreen surfaces (greeter, lock screen, screensaver, panel taskbar, etc.) can skip the Linux CSD `window_border` wrapper, which otherwise paints an unwanted border and shadow around an edge-to-edge surface. When `borderless` is set, `Root::render` returns the inner content directly instead of wrapping it in `window_border()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Root::borderless()so that layer-shell fullscreen surfaces (greeter, lock screen, screensaver, panel taskbar, etc.) can skip the Linux CSDwindow_borderwrapper, which otherwise paints an unwanted border and shadow around an edge-to-edge surface.When
borderlessis set,Root::renderreturns the inner content directly instead of wrapping it inwindow_border(). The default isfalse, so existing behavior is unchanged.Description
On Linux,
Root::renderalways wraps its content inwindow_border()to draw client-side decoration borders and shadows. For layer-shell fullscreen surfaces (greeters, lock screens, screensavers, panels, etc.) this wrapper is undesirable: such surfaces are edge-to-edge and should not have a border or drop shadow around them.This PR adds an opt-in
Root::borderless(bool)builder method backed by aborderless: boolfield (defaultfalse). Whenborderlessistrue,Root::renderreturns the inner content element directly; otherwise it keeps wrapping the content inwindow_border().shadow_size(...)exactly as before. Both branches end with.into_any_element()so the return type is unified.Because the default is
false, all existing windows are unaffected.Break Changes
None.
How to Test
cargo build -p gpui-componentRoot::borderless(true)on a layer-shell fullscreen surface and confirm the border and shadow are no longer drawn around it.Root(withoutborderless, orborderless(false)) still renders the usual border and shadow.Checklist
cargo runfor story tests related to the changes.