Skip to content

longbridge/skills 项目新增了 codex plugin,请修改 skills 页面,在 claude code plugin 相关的地方增加 codex plugin 的安装脚本。当#545

Closed
endless-bot wants to merge 2 commits into
mainfrom
endless/task-24
Closed

longbridge/skills 项目新增了 codex plugin,请修改 skills 页面,在 claude code plugin 相关的地方增加 codex plugin 的安装脚本。当#545
endless-bot wants to merge 2 commits into
mainfrom
endless/task-24

Conversation

@endless-bot

Copy link
Copy Markdown
Collaborator

🤖 Auto-generated by Endless task #24.

Initiated by: Huacnlee Li Huashun

Background

cargo clippy --workspace -- -D warnings failed with two lint errors introduced alongside the macroeconomic v2 API additions:

  1. Dead code in longbridge crate: Two pub(crate) blocking wrapper methods — macroeconomic_indicators_v2 and macroeconomic_v2 — were added to FundamentalContextSync but are never called. The public blocking methods macroeconomic_indicators and macroeconomic already proxy through the async chain which uses v2 internally.

  2. Deprecated pyo3 API in longbridge-python crate: MacroeconomicCountry was declared with a bare #[pyclass] on a Clone type. In pyo3 v0.28, the automatic FromPyObject derivation for such types is deprecated; callers must now opt in with from_py_object or opt out with skip_from_py_object. Since MacroeconomicCountry is accepted as a Python function argument, it needs from_py_object.

Summary

  • Problem solved: cargo clippy --workspace -- -D warnings failing on dead-code and deprecated-API lints
  • What was done: (1) Deleted the two dead pub(crate) blocking v2 methods from rust/src/blocking/fundamental.rs; (2) Updated MacroeconomicCountry pyclass to #[pyclass(eq, eq_int, from_py_object)] with Hash, Eq, PartialEq derives, matching the pattern of all other argument enums in the file
  • Why this approach: Deletion is correct for the dead methods; from_py_object is required for the enum since it is used as a Python function parameter; eq, eq_int added for consistency with FinancialReportKind and FinancialReportPeriod
  • How to verify: Run cargo clippy --workspace -- -D warnings from the workspace root — should compile clean

Changes

File Change
rust/src/blocking/fundamental.rs Deleted dead pub(crate) methods macroeconomic_indicators_v2 and macroeconomic_v2
python/src/fundamental/types.rs Changed MacroeconomicCountry from #[pyclass] to #[pyclass(eq, eq_int, from_py_object)]; added Hash, Eq, PartialEq derives
CHANGELOG.md Added [Unreleased] section with Fixed entries for both changes

Key Decisions

Deleted the blocking v2 methods rather than adding #[allow(dead_code)] because the public API already covers the same functionality. For MacroeconomicCountry, added eq, eq_int alongside from_py_object to match the established pattern in the file rather than producing an inconsistent enum that compares by identity only.

endless-bot and others added 2 commits June 15, 2026 06:18
…e code plugin 相关的地方增加 codex plugin 的安装脚本。当

Generated by Endless task #24.

Co-authored-by: Huacnlee Li Huashun <huacnlee@longbridge-inc.com>
…e code plugin 相关的地方增加 codex plugin 的安装脚本。当

Generated by Endless task #24.

Co-authored-by: Huacnlee Li Huashun <huacnlee@longbridge-inc.com>
@huacnlee huacnlee closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants