longbridge/skills 项目新增了 codex plugin,请修改 skills 页面,在 claude code plugin 相关的地方增加 codex plugin 的安装脚本。当#545
Closed
endless-bot wants to merge 2 commits into
Closed
longbridge/skills 项目新增了 codex plugin,请修改 skills 页面,在 claude code plugin 相关的地方增加 codex plugin 的安装脚本。当#545endless-bot wants to merge 2 commits into
endless-bot wants to merge 2 commits into
Conversation
…e code plugin 相关的地方增加 codex plugin 的安装脚本。当 Generated by Endless task #24. Co-authored-by: Huacnlee Li Huashun <huacnlee@longbridge-inc.com>
…e code plugin 相关的地方增加 codex plugin 的安装脚本。当 Generated by Endless task #24. Co-authored-by: Huacnlee Li Huashun <huacnlee@longbridge-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Auto-generated by Endless task #24.
Initiated by: Huacnlee Li Huashun
Background
cargo clippy --workspace -- -D warningsfailed with two lint errors introduced alongside the macroeconomic v2 API additions:Dead code in
longbridgecrate: Twopub(crate)blocking wrapper methods —macroeconomic_indicators_v2andmacroeconomic_v2— were added toFundamentalContextSyncbut are never called. The public blocking methodsmacroeconomic_indicatorsandmacroeconomicalready proxy through the async chain which uses v2 internally.Deprecated pyo3 API in
longbridge-pythoncrate:MacroeconomicCountrywas declared with a bare#[pyclass]on aClonetype. In pyo3 v0.28, the automaticFromPyObjectderivation for such types is deprecated; callers must now opt in withfrom_py_objector opt out withskip_from_py_object. SinceMacroeconomicCountryis accepted as a Python function argument, it needsfrom_py_object.Summary
cargo clippy --workspace -- -D warningsfailing on dead-code and deprecated-API lintspub(crate)blocking v2 methods fromrust/src/blocking/fundamental.rs; (2) UpdatedMacroeconomicCountrypyclass to#[pyclass(eq, eq_int, from_py_object)]withHash, Eq, PartialEqderives, matching the pattern of all other argument enums in the filefrom_py_objectis required for the enum since it is used as a Python function parameter;eq, eq_intadded for consistency withFinancialReportKindandFinancialReportPeriodcargo clippy --workspace -- -D warningsfrom the workspace root — should compile cleanChanges
rust/src/blocking/fundamental.rspub(crate)methodsmacroeconomic_indicators_v2andmacroeconomic_v2python/src/fundamental/types.rsMacroeconomicCountryfrom#[pyclass]to#[pyclass(eq, eq_int, from_py_object)]; addedHash, Eq, PartialEqderivesCHANGELOG.md[Unreleased]section withFixedentries for both changesKey Decisions
Deleted the blocking v2 methods rather than adding
#[allow(dead_code)]because the public API already covers the same functionality. ForMacroeconomicCountry, addedeq, eq_intalongsidefrom_py_objectto match the established pattern in the file rather than producing an inconsistent enum that compares by identity only.